Patch: Search 404 should use default search engine [#1253426]

To avoid having to rank which of the drupal native search engines to use, ie solr falling back to node, falling back to etc.. let's just use the default one set by the site builder. Will cut down on requests for integration with X search engine.

Comment	File	Size	Author
#1	search404-use-default-search-and-just-render.patch	4.55 KB	yareckon
	search404-use-default-search.patch	831 bytes	yareckon

Comments

Comment #1

yareckon commented 18 August 2011 at 19:12

Status	File	Size
new	search404-use-default-search-and-just-render.patch	4.55 KB

Well that doesn't work quite for the 7.x dev branch which now looks at $results['#results'], which for some search pages is not present. Version 2 of the patch now just passes through to drupal render when hitting one of these search providers that return a weird $results array.

My use case is display suite's ds_search module which returns it's own results format.

I also use the given search type's own search form rather than hard coding the node search form.

Comment #2

yareckon commented 18 August 2011 at 19:14

in other words the first patch barely works to make ds_search work on the 1.0 of search404 (but for all the wrong reasons)

the second patch makes ds_search work properly with 7.x-dev of search 404 (kind of properly).

Comment #3

bensey commented 30 January 2012 at 22:28

Hi there,
is this issue being solved further or rolled into dev or anything?

Display Suite provides a really simple way to customise and improve search results, and Search404's URL 404 search features are a pretty cool alternative to a classic 404 page.

It would be great if the two could work side by side.

I wish I could help, but I've reviewed the patch and my PHP and understanding of core search is a little limited to be able to assist.

Comment #4

zyxware commented 1 July 2012 at 17:45

Category:	bug	» feature
Status:	Needs review	» Needs work

@yareckon - Thanks for preparing a patch for this issue. The patch fails on the latest dev version of the module. Can you please rebuild the patch on the latest 7.x-1.x branch.

Comment #5

zyxware commented 1 July 2012 at 19:04

Assigned:	Unassigned	» zyxware
Status:	Needs work	» Fixed

@yareckon - I have managed to apply the changes manually. The changes applied were the logic for the selection of type_search and the change for handling $results array that does not have $results['#results']. Please check and confirm if things work fine. The changes have been applied to 7.x-1.x branch.