Comments showing on both node view and talk page

I am seeing this also, in the -dev version of 7 May 2012.

OK, the problem here is with talk_node_load.

It clobbers the comments conditional on:

talk_activated($node->type) && arg(0) == 'node' && !arg(2)

I don't know what this is trying to do. I'm using path aliases, and arg() sees those, not "node", so the code above definitely can't work.

Just changing it to TRUE works for me. Presumably there's some case in which that is the wrong thing?

Another thing. According to the documentation for hook_node_load:

This hook should only be used to add information that is not in the node or node revisions table, not to replace information that is in these tables (which could interfere with the entity cache).

I'm not sure, is there a caching issue here because we're "replacing information" by bashing the $node object ?

Answer: yes, there is a caching problem!

This sets the node to have $node->comment = 0. (That should actually be COMMENT_NODE_HIDDEN , not the literal 0.)

The problem is that this is cached and persists. So if you go to the talk page and post a comment, after submitting it, you get the error message "This discussion is closed: you can't post new comments.", generated by comment_reply in comment.pages.inc when $node->comment != COMMENT_NODE_OPEN (which is what it finds in the cache).

As far as I can tell, comment posting with Talk now only works when the arg(0) == 'node' && !arg(2) condition fails. (And that condition is wrong.)

[I have checked, and this code comes from the D6 version. But apparently there are core differences between D6 and D7 so it no longer works.]

It would seem that some better way of hiding the comments is needed...

So, the problem here is that talk_node_load() is called during the bootstrap, before Drupal has translated the path alias. Specifically, during drupal_bootstrap, it calls drupal_get_normal_path in order to translate aliases, during which it calls entity_load, which eventually calls talk_node_load(). So in that function, arg() still sees the alias, not /node/NID.

So, we need to clobber the comments later than hook_node_load. (And it would be better to do it in a cleaner way that doesn't muck up caching.)

It would seem that talk_node_view() is the right place. I removed talk_node_load, and added the following to talk_node_view():

  // Remove comments from page if we're viewing just it (and Talk is enabled for the node type).
  if (talk_activated($node->type) && arg(0) == 'node' && !arg(2)) {
    $node->content['comments'] = array();
  }

This seems to work. If I run into further problems, I'll follow up here.