I would like to have the option, per formatter, to hide the contextual-links-region / contextual-links-wrapper divs eg.
Now I use css based solutions but having a singe check-box would be more convenient.

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Easiest option is to turn off the Contextual links module, but clearly not a good option.

I will think on how I can do so without adding too much cruft to the module.

Out of curiosity, I am interested in knowing the justification for the request, from my point of view they're only visible to users with permission (UID 1 in most cases) and there extremely helpful. I'd love to hear your point of view.

Cheers,
Deciphered.

cees.vanegmond’s picture

cees.vanegmond commented
Status: Active » Closed (won't fix)

Reading your comments caused me to think. I'm working as UID 1 and I'm the only user at this moment on a new project. I've looked into the permissions and both Contextual links and Custom Formatters should be true to display the Edit Formatter thing. This is not applicable for any of the future roles/users.
I think my feature request can be closed (which I just did) and I have to deal with the consequences. :-)

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

I'm still happy to look into this if you think it is necessary, but will leave it for now.

Cheers,
Deciphered.

Jorenm’s picture

Jorenm commented
Status: Closed (won't fix) » Active

I actually have a case where this would be useful. I created a custom formatter which prints an images path instead of the image itself. I'm trying to place the path inside of an HTML attribute, but it breaks because it's putting html tags where I want just raw text.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Thanks Jorenm,

That's definitely a valid usecase. The easiest and most logical approach to me is that it be a global setting, much like the label prefix option is, would you be upset if that's the approach I took?

Cheers,
Deciphered.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Hi Jorenm,

I've committed a solution to this issue, dev should be built shortly.
On the Formatters 'Settings' page there is now 'Contextual links integration' settings, which allow you to disable it completely for all Formatters, or choose to include or exclude specific Formatters.

Let me know how this goes for you.

Cheers,
Deciphered.

cees.vanegmond’s picture

cees.vanegmond commented
Status: Active » Fixed

Hi,
Meanwhile I've tested the latest dev and the settings and removal of contextual-links works as expected.
No errors seen.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Jorenm’s picture

Jorenm commented

I don't even remember making this ticket, but I came back 2 years later looking for the same thing, and it came in handy that you added this. Belated thanks to you. :)