Last commit broken the l10n_server

Parse error: syntax error, unexpected '@', expecting ',' or ')' in /..................../l10n_server/l10n_packager/l10n_packager.module on line 245

 function l10n_packager_get_filepath($release, $language = NULL, $pattern = NULL) {
-   // Get version information from release title
-   if ($release->uri == 'drupal') {
-     // Core releases are like: 6.1, 6.2, 6.x-dev, 6.x-beta1
-     @list($version, $extra) = explode('-', $release->title);
-     list($major, $minor) = explode('.', $version);
-     $core = $major . '.x';
-   }
-   else {
-     // Modules are like: 6.x-1.0, 6.x-1.x-dev, 6.x-1.0-beta1
-     @list($core, $version, $extra) = explode('-', $release->title);
-     list($major, $minor) = explode('.', $version);
-   }
-   $replace = array(
+  // Get version information from release title
+  if ($release->uri == 'drupal') {
+    // Core releases are like: 6.1, 6.2, 6.x-dev, 6.x-beta1
+    list(@$version, $extra) = explode('-', $release->title);
+    list($major, $minor) = explode('.', $version);
+    $core = $major . '.x';
+  }
+  else {
+    // Modules are like: 6.x-1.0, 6.x-1.x-dev, 6.x-1.0-beta1
+    list(@$core, $version, $extra) = explode('-', $release->title);
+    list($major, $minor) = explode('.', $version);
+  }
+  $replace = array(

http://drupalcode.org/project/l10n_server.git/blobdiff/e4354241da6556b8c...

Comments

gábor hojtsy’s picture

Status: Active » Fixed

Thanks, I put back the @ operators to where they were :) Unfortunately there is no automated testing for this part of the module. Similar little automated code style parser issues were noticed elsewhere by the tests.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.