Ugh

CommentFileSizeAuthor
#5 1128446-view-key-5.patch2.1 KBpwolanin
#4 1128446-view-key-4-D6.patch2.06 KBpwolanin
#2 1128446-view-key-2-D6.patch2.19 KBpwolanin
#1 1128446-view-key-1-7x.patch2.23 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 1128446-view-key-1-7x.patch2.23 KB
pwolanin’s picture

pwolanin commented
StatusFileSize
new 1128446-view-key-2-D6.patch2.19 KB

Hete's the 6.x-2.x version.

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

Needs a re-roll for #1026444: Alter or explain comment stripping? since key comments are not stripped, we should just print the original key

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1128446-view-key-4-D6.patch2.06 KB

Here's a re-roll for D6 which also fixes the call to drupal_set_header()

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 1128446-view-key-5.patch2.1 KB

Here's the 7.x version

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

We don't need the 'modal' => TRUE line on the menu callback as this is not something that would open in a modal UI for editing.

+    $operations['view'] = array(
+      'title' => t('View'),
+      'href' => "ssh-keys/{$entity_type}/{$entity_id}/{$key_id}/view",
+      'modal' => FALSE,
+    );

This should probably check sshkey_access('view'). Also take out 'modal' => FALSE. And I think the current code has a variable with the base URI of the sshkey so it doesn't have to be a long string join.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Committed to 7.x-2.x with additional updates to the Views integration. Also backported to 6.x-2.x.
http://drupalcode.org/project/sshkey.git/commit/103734f (7.x-2.x)
http://drupalcode.org/project/sshkey.git/commit/119feb4 (6.x-2.x)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: 1128446-view-key-5.patch, failed testing.

The last submitted patch, 1: 1128446-view-key-1-7x.patch, failed testing.

The last submitted patch, 1: 1128446-view-key-1-7x.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)