Hey xibun, nothing serious, but found a php notice for using an undefined variable. On line 178 in uc_bank_transfer.module the $output variable is being returned, but it will only have been set if a clear_date was found on line 174.

Attached a patch (don't know if it was necessary) to set $output to an empty string so it will have been set even if no clear date was found. At least it will help clarify what I'm saying...

CommentFileSizeAuthor
#1 uc_bank_transfer.patch785 bytesxibun
uc_bank_transfer.patch545 bytesdaniel bornman

Comments

xibun’s picture

xibun commented
StatusFileSize
new uc_bank_transfer.patch785 bytes

Hi danielbornman, good catch!

actually we can even use this to communicate the pending status to the customer. also it seems to me there was a mark-up bug. have a look at the proposed patch with both changes.

daniel bornman’s picture

daniel bornman commented

That looks even better - nice touch, like the 'Status pending'

xibun’s picture

xibun commented
Status: Needs review » Fixed

committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.