Since you are using the open twitter json format there is a limit of 150 calls from a client, not really a problem BUT while developing and refreshing the site several time you easily get up to 150.

The module needs some kind of system that if it dosen't get any tweets returns a "tweet" that says "limit reached" or something. In it's current state the site takes forever to load (if it loads at all) and the twitter block seems to have crashed

Comments

ZenDoodles’s picture

Assigned: Unassigned » ZenDoodles
Issue tags: -tweet, -limit

You're absolutely right, but I don't expect to have time to work on this for a couple of weeks.

I'd probably accept a patch though!

benjamin.wallberg’s picture

Priority: Critical » Normal
Status: Active » Fixed
StatusFileSize
new1.61 KB

Patch incoming! :) Patch caches the json reply. This is mainly good for development since if you activate cache block it will cache the block if you are a logged in user or anonymous. But not as admin! This is were this patch is great, since mostly you will reach the limit during development.

oranges13’s picture

I selected 2 as the limit and it still shows about 10 tweets.

ZenDoodles’s picture

@benjamin.wallberg I just looked at this. Very nice. Will test and hopefully commit this weekend. Thanks so much!

@oranges13 This issue talks about the twitter api limit. Twitter limits the number of times we can query the api anonymously, and this addresses that. The number of tweets returned in the block is not the same thing, however it is resolved in the dev version. If it is not, please open a new ticket, or reopen #1052570: Tweets not limited/filtered as expected.

Thanks!

ZenDoodles’s picture

Status: Fixed » Needs review
oranges13’s picture

Hey thanks. But I've found another bug, will post about it.

ZenDoodles’s picture

Status: Needs review » Closed (fixed)

Patch included in 7.x-1.0-beta1 release. http://drupal.org/node/1135176

Thanks @benjamin.wallberg!