Currently this module doesn't work at all with clean urls disabled.

1. Should add a hook_requirements() to make that explicit
2. Consider doing unclean-url support the same way that core image module does it, however that currently has some issues of its own #1025124: Remove cruft from theme_image_style() and image_style_url().

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Postponed

Added #1. Marking this postponed on #1025124: Remove cruft from theme_image_style() and image_style_url() for the rest.

drupa11y’s picture

drupa11y commented

Subscribe: could help testing.

catch’s picture

catch
he/him
Primary language English
commented
Title: Support clean URLs » Support non-clean URLs

Correcting issue title.

catch’s picture

catch
he/him
Primary language English
commented
Category: bug » feature
dropbydrop’s picture

dropbydrop commented

sub

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented

Now that #1025124: Remove cruft from theme_image_style() and image_style_url() and #1025124: Remove cruft from theme_image_style() and image_style_url() have been addressed, is there anything else needed but starting with hook_requirements() to move this forward?

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented

Ahem, it looks like it's already been implemented in http://drupalcode.org/project/agrcache.git/blob/HEAD:/agrcache.install