Problem/Motivation

Sometimes patches put on an issue are not sent to the testbot for testing.

Examples

Other issues

might be related to

This is *not* the same as other reasons things might not get tested.
Which are:

Proposed resolution

Remaining tasks

User interface changes

API changes

Comments

yesct’s picture

yesct commented

this might need to be moved to another d.o issue queue

yesct’s picture

yesct commented
Issue summary: View changes

added an example to the issue summary.

other people should add more examples.

dddave’s picture

dddave commented
Project: Drupal.org site moderators » Drupal.org customizations
Version: » 7.x-3.x-dev
Component: Project/Git problem » Tests

First guess for project

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Drupal.org customizations » Project issue file test
Version: 7.x-3.x-dev » 7.x-2.x-dev
Component: Tests » Code

Seeing a screenshot of the messages as the comment is posted would be helpful. That will help narrow down the problem; if the message says it is queued as normal, then the bug is likely happening later as the tests are sent over. If the message is not there, then we know the problem is happening at the time of comment.

dawehner’s picture

dawehner
Primary language German
commented

Note: The first example is caused by an accident delete of the existing patches, not sure how this happened, but its the reason why the testbot was never able to pick it up.

yesct’s picture

yesct commented

I'm not sure how to get a screenshot of the messages as the comment is posted... if I come upon the patch later, and I didn't upload it.

Another one:
Project Issue File Review #2206501-40: Remove dependency on Drush from test reviews

yesct’s picture

yesct commented

Sorry, ignore #6, that one doesn't have testing enabled.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Confirmed. Seeing this at:

  1. #2289917: Convert "messages" page element into blocks: both https://qa.drupal.org/pifr/test/974633 and https://qa.drupal.org/pifr/test/974638
  2. #2368987: Move internal page caching to a module to avoid relying on config get on runtime: https://qa.drupal.org/pifr/test/973898 (which is just a retest, not a new patch)

d.o shows them as "being tested". But they're not listed at https://qa.drupal.org/pifr/queued at all. Their status is all "postponed".

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Critical
jthorson’s picture

jthorson commented
Priority: Critical » Normal

Head failed last night ... postponed is the expected behavior for tests where we don't have a clean branch to test against.

yesct’s picture

yesct commented

If a patch is uploaded and the status is needs work. later someone "hides" the patch. and later the status is changed to needs review, the patch will not be tested.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#10: aha, thanks for the clarification! So the system auto-recovered?

jthorson’s picture

jthorson commented

Yes, any postponed tests will automatically be re-queued as soon as the associated branch test goes green.

In the case of a false negative head failure, many folks in the community can force the test to retest without waiting for the branch to retest, by using the retest functionality on qa. drupal.org.

yesct’s picture

yesct commented

seems like the not-hidden patch from #2142993-34: Test for EntityChangedConstraintValidator should have had a test request sent to the bot, when the issue was set to needs review in comment 35.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Closed (cannot reproduce)