Closed (fixed)
Project:
Paragraphs
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Mar 2015 at 13:41 UTC
Updated:
9 Jan 2018 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pivica commentedOK here is a first patch for this, next stuff is done
Attaching screenshot how stuff looks now (node edit and node view)
node edit

node view

Maybe for the future we could add next things (not sure is there a real value or is it just waste of time):
Comment #2
miro_dietikerOh that's really nice. Just small things unclear to me.
VERSION?
Additionally, i'm a little bit confused about all the proposed config changes. Is an updated core leading to different export sequence or anything else?
In general, dropping "demo" in field labels makes sense.
Can you elaborate the changes a bit more? Or possibly i should review the demo setup after installation.
This issue is not about configurability. It's about lowering the barriers to make a possible user understand the paragraphs concept. Note also that tools like display suite and friends can be used with Paragraphs.
Your suggestions about configurable layout are unclear to me. Please create separate issues so we can discuss the ideas and exchange mockups there if needed.
Comment #3
pivica commentedYeah copy&paste error, changed it to version: 1.0
In config files 4 things are changed:
The rest of the stuff just came from config export - I guess because of various changes in core export.
Its not really full configurable layout, simple idea we have one additional select box field for image/text combination with some values like: 25/75, 33/66, 50/50, 66/33, 75/25, 100/100. Then when displaying paragraph we inject value from that select box as a css class, for example paragraph-layout-25-70 and then show image with 25% width and text with 75%.
Similar for images - but it would be probably more complex for rendering because we probably need then row wrappers.
Still I don't think that this should go to paragraph_demo, this would then be paragraph_layouts, and current css from paragraph_demo would be 50/50 for image/text combination.
Yeah we could also create templates/css for display suite. More over it seems that layout plugin will maybe go into 8.1.x core version #2296423: Implement layout plugin type in core, so i guess it has more sense to create templates based on layout_plugin module and not provide our custom solution. Our paragprah_demo would then also use this layouts and would not ship with custom css.
Here is a separate issue where we can discuss further this idea #2449347: Can we use layout_plugin module to provide different templates for paragraphs.
Attaching new patch - just version string fix.
Comment #4
pivica commentedAnd just did full reinstall of drupal and paragraphs_demo, everything looks OK and works as expected from my side.
Comment #5
miro_dietikerConfigurability of the aspects contains a mismatch in that different ratios need different screen sizes that are usually configured per display mode.
We would need to reconfigure image styles per layout chosen..?
Demo should show the power of the module. So in case there is an awesome layout concept that well fits the paragraphs vision, we also should ship a demo variant.
Comment #6
pivica commentedIf I remember correctly in D8 there is breakpoint support for image styles with responsive_image core module - are you talking about this? So I guess we do not need to worry about this in paragraphs layout it is a separate thing which should already be supported.
Thinking a bit more about repsonsivnes our paragraph layout should also be repsonsive somehow, not sure how to approach this for now, adding note to #2449347-1: Can we use layout_plugin module to provide different templates for paragraphs.
Comment #7
miro_dietikerTested it through the UI. Verry nice work. A perfect start to show the functionality for quick demos or even presentations.
Just...
# drush en -y paragraphs_demo
And then let's *rock*!
Comment #8
jeroen.b commentedThanks, looks great! Committed to dev.
Comment #10
miro_dietikerMoving to demo component.
Comment #12
jhmnieuwenhuis commentedThis works for Bartik theme, but not for Bootstrap theme.
Can not seem to find the issue, any ideas?
Regards,
Hans