There has been a bunch of changes to the common solr configs and one noticable one is the change in splitOnCaseChange.
A reindex is required to have the change to have any effect on your index.

Comments

nick_vh’s picture

Status: Active » Needs review
StatusFileSize
new67.64 KB
nick_vh’s picture

The space changes are intended. We want to stay as closely as possible to the solr config files.

nick_vh’s picture

Issue summary: View changes
drunken monkey’s picture

StatusFileSize
new12.44 KB
+++ b/solr-conf/3.x/solrconfig.xml
@@ -1089,7 +1090,7 @@
-         <str name="confFiles">${solr.replication.confFiles:schema.xml,mapping-ISOLatin1Accent.txt,protwords.txt,stopwords.txt,synonyms.txt,elevate.xml}</str>
+         <str name="confFiles">${solr.replication.confFiles:schema.xml,protwords.txt,stopwords.txt,synonyms.txt,elevate.xml}</str>

See #2083625-15: Strip diacritics from indexed content and query strings..

Also, you only updated the version number for 3.x/schema.xml and 4.x/solrconfig.xml, but not for 4.x/schema.xml and 3.x/solrconfig.xml.

The space changes are intended. We want to stay as closely as possible to the solr config files.

To which ones? If you mean the default ones packaged with Apache Solr, I don't see the point. If you mean the ones in the common config module – then we should probably fix the whitespace issues, typos and comment standard violations in the common configs project. I can just post a patch for that there, if you want.
Otherwise, I'd rather keep the ones in my module in line with the Drupal coding standards. As long as there is no difference in a parsed part, there shouldn't be any compatibility issues. Porting common config changes to this module becomes a bit harder, of course, but I'm usually the one doing that anyways, and I find it worth the trouble.

So, the attached patch only includes the necessary changes, fixes the above-mentioned issues and also a few more wrong indents and typos I found.
Please tell me if you'd consider committing this version to the common configs project, too. It would really simplify the creation of patches (not because of the differences to this module, but because most Drupal developers will have their editors set up to remove trailing whitespace automatically, and thus always have to fight a bit to limit a patch to the intended changes).

nick_vh’s picture

I agree with you in terms of coding standards but we had this discussion before in the common schema config project and there we decided we'd lean as closely as possible to the original schema. Including the spaces etc.

I vouch for moving this discussion about spacing etc to the common project and once we have an agreement there we can push that upstream. Until that moment I think we should keep our files identical, including the space issues.

History of the space discussion: https://drupal.org/node/1812322 -> you even started the discussion ;-)

pwolanin’s picture

I agree with Nick - we did this with the spaces so we could easily diff to the upstream files and more easily see if there were any meaningful changes to bring in.

certainly we could diff -w, but this is XML not PHP, so I don't think it's worth the hassle.

drunken monkey’s picture

Ah, yes, some time after posting my comment I remembered already discussing this once.
See #2158939: Fix typos and other small mistakes and #2158957: [policy] Make config files conform to Drupal's coding standards or keep them as close as possible to Solr's defaults? for the spin-offs in the common config project.

drunken monkey’s picture

Status: Needs review » Fixed

I've now committed my patch from #4, so there won't be two unnecessary huge changes in case we end up adapting the common configs to the Drupal coding standards as well. Otherwise, we'll just create a follow-up issue to copy these changes over as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.