#2138239: Use GlobIterator instead of glob swtiched from glob() to GlobIterator() for a bunch of things, but they have different first arguments, glob takes a pattern while GlobIterator takes a path. Apparently, this broke everything on Windows because the path needs to be absolute..

CommentFileSizeAuthor
#4 2139407-4.patch1.36 KBamateescu
#1 2139407.patch1.85 KBamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 2139407.patch1.85 KB

This patch fixes it. Since we don't have a testbot on Windows, you'll have to take my word for it :)

damiankloip’s picture

damiankloip commented

Yeah, I had suspicions this would be the issue after you mentioned it on irc. This fix looks good to me. Don't see why that wouldn't pass the bot.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented

i'm confirming that there is no way to install D8 after #2138239: Use GlobIterator instead of glob is pushed.

got an error

Additional uncaught exception thrown while handling exception.

Original

Drupal\Core\Config\StorageException: Missing configuration file: system.theme.global in Drupal\Core\Config\InstallStorage->getFilePath() (line 54 of Z:\home\d8\www\core\lib\Drupal\Core\Config\InstallStorage.php).

Additional

Drupal\Core\Config\StorageException: Missing configuration file: system.site in Drupal\Core\Config\InstallStorage->getFilePath() (line 54 of Z:\home\d8\www\core\lib\Drupal\Core\Config\InstallStorage.php).

#2139407-1: HEAD broken on Windows patch works good for me.

+1 for RTBC

amateescu’s picture

amateescu commented
StatusFileSize
new 2139407-4.patch1.36 KB

I realised I took the wrong approach in the patch, what we need to fix is the GlobIterator instantiation, not every place that deals with the config dir.

jesse.d’s picture

jesse.d commented

This worked for me as well.

I had the same errors as #3. patch in #4 fixed the install process for me.

Status: Needs review » Needs work

The last submitted patch, 1: 2139407.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review

4: 2139407-4.patch queued for re-testing.

michaellander’s picture

michaellander commented

I had the same issue as #2139407-3: HEAD broken on Windows and #2139407-4: HEAD broken on Windows resolved the issue for me as well.

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Thanks everyone for testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.