Add a UrlGenerator helper to FormBase and ControllerBase

+++ b/core/modules/shortcut/lib/Drupal/shortcut/Controller/ShortcutSetController.php
@@ -50,7 +50,7 @@ public function addShortcutLinkInline(ShortcutSetInterface $shortcut_set, Reques
-      return new RedirectResponse($this->urlGenerator()->generateFromPath('<front>', array('absolute' => TRUE)));
+      return $this->redirect('front', array());

Whoo! This is nice.

I don't think we need further test coverage here, we either have the coverage for the form or we don't, and the API we're using has coverage.
The docs are excellent, especially all of the @throws part, that's helpful.

+++ b/core/lib/Drupal/Core/Controller/ControllerBase.php
@@ -180,4 +180,49 @@ public function redirect($route_name, array $parameters = array(), $status = 302
+   * @param string $name
+   *   The name of the route

Can we name this $route_name in FormBase and ControllerBase? In UrlGenerator::generatorFromRoute() it's clear what $name means, but here it would be useful to be more explicit IMO.

Makes sense to me - also makes it consistent with the redirect() method. Just changing the variable names, so leaving at rtbc.

Noticed some strange whitespace, so quickly re-rolled for that. Leaving RTBC.

+++ b/core/modules/shortcut/lib/Drupal/shortcut/Controller/ShortcutSetController.php
@@ -50,7 +50,7 @@ public function addShortcutLinkInline(ShortcutSetInterface $shortcut_set, Reques
-      return $this->redirect('front');
+      return $this->redirect('<front>');

This actually indicates that we have missing test coverage for adding a shortcut inline. Opened #2075557: Missing test coverage for adding a shortcut link inline for that. (See also the attached screenshot.)

So we've had 4 patches since the rtbc in #2. Setting back to needs review so we can ensure that the current patch should be rtbc.

As a follow-up we should add another redirect() method (?) that takes a route and params?

Yes, this looks good.

Needs a reroll

git ac https://drupal.org/files/2073813-8-controller-form-base-url.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9885  100  9885    0     0  10179      0 --:--:-- --:--:-- --:--:-- 12481
error: patch failed: core/lib/Drupal/Core/Form/FormBase.php:8
error: core/lib/Drupal/Core/Form/FormBase.php: patch does not apply

Added Drupal:url() back to #2078285: Add short-cut methods to the \Drupal class for generating URLs and links from routes, since it's not in the patch and seems better suited there?

trivial conflict in the use statements due to the patch that added renamed to Drupal\Core\DependencyInjection\ContainerInjectionInterface;

updated the issue summary a bit

Updated issue summary.

Updated issue summary.

Let's not add all of those docs for url() multiple times, but rather put a @see in there, similar to how we do t().

Also while rerolling, be sure to say URL in comments, not url (when its not the class name)

how about this?

dawehner points out that the docs are actually on the interfaces.

Patch no longer applies.

Committed 95c2e17 and pushed to 8.x. Thanks!

#2083415: [META] Write up all outstanding change notices before release

#2083415: [META] Write up all outstanding change notices before release

I think the text on the pages is sufficient. Example code isn't needed for these functions as long as there is at least one occurrence in core as reference I guess.

Untagging. Please remove the "Needs change notification" tag when the change notice task is complete.

d.o--

So we need to reference this issue on those two change notices.

**sigh**

Updated issue summary.

I added this issue to the two change notices, if that's all that's needed on top of @dawehner's edits this issue can be closed now.

https://drupal.org/node/2060189
https://drupal.org/node/2076011