I decided to review ctools module with pareview.sh online service and got a lot of errors like

./page_manager/page_manager.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function page_manager_schema() {
function page_manager_schema_1() {
function page_manager_install() {

http://pareview.sh/pareview/httpgitdrupalorgprojectctoolsgit

Ctools is a module which has a lot of sub-modules. For example ctools has sub-module called "page_manager" located in "ctools" parent folder. All hooks of page_manager sub-module must be prefixed with "page_manager_". But pareview.sh does not understand it.

Please, tell me if I am wrong!

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Closed (works as designed)

Yep, Ctools does it wrong: all sub-modules within one project should be prefixed with the main module name to avoid name clashes. If somebody creates a page_manager project there will be fatal errors because of ctools ...

So this is working as expected!

dragon658’s picture

dragon658 commented

Thank you!