Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The path for this tour admin/structure/views/view/*/edit is not activated as the view edit is on path admin/structure/views/view/* for some reason.
Furthermore the Tour scheme is changed not having a module entry.
Attached patch has the view adjusted to the new scheme and the changes from the sandbox version. For reference see contrib Tour UI #2025195: Better views tour?
It needs a change on path by either fix view/*/edit or remove that path.
Comment | File | Size | Author |
---|---|---|---|
core-views_ui-tour-edit.patch | 4.87 KB | clemens.tolboom | |
Comments
Comment #1
clemens.tolboomAdding tour tag.
Comment #2
aspilicious CreditAttribution: aspilicious commentedLacking tests?
Comment #3
clemens.tolboom@aspilicious interesting ... what tests do you have in mind?
In XREF #1921152-47: META: Start providing tour tips for other core modules. I suggest we provide a base test class from Tour module.
Comment #4
nick_schuch CreditAttribution: nick_schuch commentedHi Clemens,
Thanks for providing a patch to fix the change in views ui. I have looked and can see the "module" is still provided on the Tour entity:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/tour/li...
I will look into the tests as they should have failed on your patch.
I really busy today but will find time to review this patch.
Comment #5
nick_schuch CreditAttribution: nick_schuch commentedWe are testing if the "module" class is provided/used:
http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/tour/li...
However, we do not test other module tour content (this are purely functionality) tests.
You could:
1) Write for View UI module to confirm the fail.
2) Supply a patch with the fix (which you have provided) and the test.
Comment #6
clemens.tolboomModule in not defined in the Tour Schema. It is required by #2022087: Add module owner to plugin definition in AnnotatedClassDiscovery. Not sure whether that's equivalent :/
Let's focus on #2028535: Provide a TourTestBase class for use by core and contrib modules for schema validation and other stuff.
Comment #7
clemens.tolboomI found the path problem regarding views. It's router has two path
- pattern: '/admin/structure/views/view/{view}'
- pattern: '/admin/structure/views/view/{view}/edit/{display_id}'
Where it's default for {default_id} is NULL
I guess the tour must be available on 3 paths
- /view
- /view/*/edit
- /view/*/edit/*
Still working on #2028535: Provide a TourTestBase class for use by core and contrib modules
Comment #8
tim.plunkett/view/*/edit should not work, the fact it does is by coincidence
Just go with /view and /view/*/edit/* please.
Comment #9
xjmSee #2040369: The Views UI tour is broken.