Change status filter on admin/people to 'active'/'blocked'

changes defaults for the status exposed filter to 'active' or 'blocked', instead of yes/no. also updates the default label to "Active status".

OH, there are actually bugs in the code.

thanks @dawehner. i added a minor typo fix in the new test.

+++ b/core/modules/views/lib/Drupal/views/Tests/Handler/FilterBooleanOperatorTest.phpundefined
@@ -98,5 +98,81 @@ public function testFilterBooleanOperator() {
+  public function testFilterGroupedExposed() {

Needs a docblock.

Otherwise, looks good to go!

There we go.

Thank you, looks fine. I expected that to pass, as it's just a comment addition.

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

I get the 'active/blocked' change but not 'Active status'. Why not just 'status'?

@catch: i was going for consistency with views hook_views_data() declaration in core/modules/user/user.views.inc...

$data['users']['status'] = array(
    'title' => t('Active status'),
    'help' => t('Whether a user is active or blocked.'),
    ...

but, "Active" does seem more straight forward for the UI.

interfidd :)

OH i thought catch suggested to use "Status" and not "Active" ?

you're right! sorry about that.

whoops (again), patched against wrong branch! here we go again.

Thank you!

#16 looks like the wrong patch.

Also why not change the user views data to 'Status' instead of 'Active status' rather than the default view in this case?

Sorry about #16. Here's a re-roll with suggestions from #18, changing the field label to only 'Status'.

I am sorry that I didn't looked at the actual patch.

Committed/pushed to 8.x, thanks!