Rename Views method get_field() to getField()

Replaced get_file with getFile across several views.core files. Patch attached.

I believe there to be a bug in the test, not in the code submitted in comment #3. The test fails randomly, with no change in the code

#2: views.core-replace_get_file_with_getfile-2002910-02.patch queued for re-testing.

I think the patch in comment #2 (and I apologize that I didn't notice you had taken this task before I made my patch) is missing changes to the following two files:

• core/modules/contextual/lib/Drupal/contextual/Plugin/views/field/ContextualLinks.php
• core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php

I suspect the second one is what's causing the failure in HandlerFieldFieldTest. I'm convinced that it's something outside of either of these patches that's causing the BlockRenderOrderTest random failure

#3: Rename-Views-method-get_field-to-getField-2002910-1.patch queued for re-testing.

#3: Rename-Views-method-get_field-to-getField-2002910-1.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/row/RssFields.phpundefined
@@ -187,15 +187,15 @@ function render($row) {
+  function getField($index, $field_id) {

Add public access modifier in front of the function to adher to the new OOP standards.

Added public access modifier to getField function in RssFields class as recommended in #11

Updated instances of get_field() in HandlerFieldFieldTest.

Updating status to needs review.

Looks good to me now !

Seems like we've added a new one in Drupal\contextual\Plugin\views\field\ContextualLinks

$rendered_field = $this->view->style_plugin->get_field($this->view->row_index, $field);

Replaced more instances of get_field() with getField()

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -740,7 +740,7 @@ function hasDefaultArgument() {
-  function get_default_argument() {
+  public function getDefaultArgument() {

@@ -1014,7 +1014,7 @@ function get_value() {
-      $arg = $argument->get_default_argument();
+      $arg = $argument->getDefaultArgument();

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Date.phpundefined
@@ -57,7 +57,7 @@ public function defaultArgumentForm(&$form, &$form_state) {
-  function get_default_argument($raw = FALSE) {
+  public function getDefaultArgument($raw = FALSE) {

Out of scope for this issue.

Awesome!

Looks good to me !

Committed b48343a and pushed to 8.x. Thanks!