Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#15 content-translation-add-page-1987876-15.patch7.47 KBsidharthap
#13 content-translation-add-page-1987876-13.patch7.43 KBsidharthap
#5 translation-entity-form-interface-1987876-5.patch37.73 KBinternetdevels

Comments

acrollet’s picture

acrollet commented
Assigned: Unassigned » acrollet

having a look at this one.

acrollet’s picture

acrollet commented

This issue is blocked on #1987882: Convert content_translation routes to a new style controller

acrollet’s picture

acrollet commented
Assigned: acrollet » Unassigned
internetdevels’s picture

internetdevels commented
Assigned: Unassigned » internetdevels

We are working today with this issue during Code Sprint UA

internetdevels’s picture

internetdevels commented
StatusFileSize
new translation-entity-form-interface-1987876-5.patch37.73 KB

Wrong issue. Please ignore this comment and this patch.

internetdevels’s picture

internetdevels commented
Status: Active » Needs work
Issue tags: +CodeSprintUA

Work on this task was continued in #1987882: Convert content_translation routes to a new style controller .

vijaycs85’s picture

vijaycs85
Location London, UK
commented

Blocked by #2024867: Rename translation_entity to content_translation

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Postponed
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs work

We can't afford to wait on this, and git can help resolve any rename issues. Plus there isn't consensus on the naming in that issue.

internetdevels’s picture

internetdevels commented
Assigned: internetdevels » Unassigned
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Convert translation_entity_add_page() to a new style controller » Convert content_translation_add_page() to a new style controller
Component: translation_entity.module » content_translation.module
sidharthap’s picture

sidharthap
Primary language English
commented
Assigned: Unassigned » sidharthap
sidharthap’s picture

sidharthap
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new content-translation-add-page-1987876-13.patch7.43 KB

Status: Needs review » Needs work

The last submitted patch, content-translation-add-page-1987876-13.patch, failed testing.

sidharthap’s picture

sidharthap
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new content-translation-add-page-1987876-15.patch7.47 KB

Status: Needs review » Needs work

The last submitted patch, content-translation-add-page-1987876-15.patch, failed testing.

disasm’s picture

disasm commented
Status: Needs work » Closed (duplicate)

Work is happening here #1987882: Convert content_translation routes to a new style controller since all of these are very dependent on each other being in the same for loop for generation.