Patch passed all argument and argument validator tests on my localhost...EXCEPT for the date argument handler test. However, that test fails even with the patch not applied, so I think that must be different issue.
Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.
curl http://drupal.org/files/views-2003356-processSummaryArguments.patch | git a
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4061 100 4061 0 0 7609 0 --:--:-- --:--:-- --:--:-- 11407
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:754
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
Comments
Comment #1
phenaproximaComment #2
phenaproximaPatch passed all argument and argument validator tests on my localhost...EXCEPT for the date argument handler test. However, that test fails even with the patch not applied, so I think that must be different issue.
Comment #3
elvis2 commentedThanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.
You can see an example patch here: http://drupal.org/node/2001672
Comment #4
phenaproximaAdded the public modifier to all the functions in the patch.
Comment #5
phenaproxima...and marking as needing review. :)
Comment #6
oenie commentedLooks fine to me !
Comment #7
oenie commentedAnd thanks elvis2 for helping out ... paying it forward rocks ! :)
Comment #8
alexpottNeeds a re-roll
Comment #9
jibranreroll
conflict
resolved like this
Comment #11
elvis2 commentedComment #12
jibran#9: 2003356-9.patch queued for re-testing.
Comment #14
drupalway commentedWe are working today with this issue during Code Sprint UA
Comment #15
drupalway commentedRe-rolled. Please review.
Comment #17
SpartyDan commentedRe-rolled
Comment #18
heddnLooks good.
Comment #19
aspilicious commentedagree :)
Comment #20
alexpottCommitted da83b1a and pushed to 8.x. Thanks!