Replace theme() with drupal_render() in system module for theme_system_themes_page()

WDG (Ukraine,Kharkov) want to implement this on Code Sprint UA.

could not apply #5, throws fatal:corrupt patch at line 41.
re-rolling.

+        foreach ($theme->screenshot as $key => $value) {
+          $image['#' . $key] = $value;
+        }

Don't do this, explicitly set each variable that #theme 'image' is expecting. Please see the issue summary for the parent issue for more details.

+        $links = array(
+          '#theme' => 'links',
+          '#links' => $theme->operations,
+          '#attributes' => array(
+            'class' => array('operations', 'clearfix')
+          )
+        );

missing trailing commas in here.

needed a reroll too, so...

I set the theme to the default and changed the theme a few times. I encountered no errors, everything looks good! Changing to reviewed and tested by the community.

+++ b/core/modules/system/system.admin.incundefined
@@ -1281,7 +1281,19 @@ function theme_system_themes_page($variables) {
-      $screenshot = $theme->screenshot ? theme('image', $theme->screenshot) : '<div class="no-screenshot"><div class="no-screenshot__text">' . t('no screenshot') . '</div></div>';
...
+        $screenshot = '<div class="no-screenshot">' . t('no screenshot') . '</div>';

The markup is changing here but shouldn't - we are missing the no-screenshot__text div.

Fixed markup change noted in #13.

#14: twig-replace_themes_page-2010086-14.patch queued for re-testing.

Seem to be missing a call to theme('system_themes_page') in system.admin.inc @ line 221.

@heddn, I think this issue only covers the theme() calls in theme_system_themes_page(). It seems all other calls are being sorted out in #2009674: Replace theme() with drupal_render() in system module.

BTW, the patch looks good and applies cleanly.

@hussainweb, good clarification. I agree this looks RTBC.

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

Committed 1a0f40d and pushed to 8.x. Thanks!