Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#19 rdf-replace_theme-2009664-19.patch1.45 KBhussainweb
#17 rdf-replace_theme-2009664-15.patch1.45 KBjeroent
#15 rdf-replace_theme-2009664-15.patch1.45 KBjeroent
#12 drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch1.41 KBesunger
#11 drupal_replace_theme_with_drupal_render_rdf_module-2009664-11.patch1.41 KBesunger
#9 drupal_replace_theme_with_drupal_render_rdf_module-2009664-9.patch1.38 KBesunger
#7 drupal_replace_theme_with_drupal_render_rdf_module-2009664-7.patch3.4 KBesunger
#3 drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch1.38 KBesunger
#1 2009664-replace_theme_with_drupal_render_in_rdf-1.patch824 bytesaaronott

Comments

aaronott’s picture

aaronott commented
Status: Active » Needs review
StatusFileSize
new 2009664-replace_theme_with_drupal_render_in_rdf-1.patch824 bytes
esunger’s picture

esunger commented
Assigned: Unassigned » esunger
Status: Needs review » Active
esunger’s picture

esunger commented
StatusFileSize
new drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch1.38 KB

New version of the patch with added missed drupal_render() functions.

esunger’s picture

esunger commented
Status: Active » Needs review
esunger’s picture

esunger commented
Issue tags: +CodeSprintUA

Status: Needs review » Needs work

The last submitted patch, drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch, failed testing.

esunger’s picture

esunger commented
StatusFileSize
new drupal_replace_theme_with_drupal_render_rdf_module-2009664-7.patch3.4 KB
esunger’s picture

esunger commented
Status: Needs work » Needs review
esunger’s picture

esunger commented
StatusFileSize
new drupal_replace_theme_with_drupal_render_rdf_module-2009664-9.patch1.38 KB
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work 
+++ b/core/modules/rdf/rdf.moduleundefined
@@ -461,7 +461,13 @@ function rdf_process(&$variables, $hook) {
+      $variable = array(
+	'#theme' => 'rdf_template_variable_wrapper',
+	'#content' => $variables[$variable_name],
+	'#attributes' => $attributes,
+	'#context' => $context,

https://drupal.org/coding-standards#indenting
Indenting errors

esunger’s picture

esunger commented
Status: Needs work » Needs review
StatusFileSize
new drupal_replace_theme_with_drupal_render_rdf_module-2009664-11.patch1.41 KB

Thanks. Indenting errors were solved.

esunger’s picture

esunger commented
StatusFileSize
new drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch1.41 KB
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

#12 looks good for me
if bot green - rtbc

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new rdf-replace_theme-2009664-15.patch1.45 KB

Replaced theme with drupal_render

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Needs work

+ '#metadata' => $variables['rdf_metadata_attributes']

missing a trailing comma on this line.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new rdf-replace_theme-2009664-15.patch1.45 KB

Added trailing comma.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Needs work

+ '#metadata' => $variables['rdf_metadata_attributes']

Still no trailing comma in #17

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new rdf-replace_theme-2009664-19.patch1.45 KB

Added a trailing comma and made sure it applies against the latest tree.

sbudker1’s picture

sbudker1 commented
Status: Needs review » Reviewed & tested by the community

The patched worked! After inspecting the element of the submission, the rdf markup there contained normal rdf attributes. In addition the entire submission and appearance of the submission were normal.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8678e21 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.