This a subtask of issue 421118 for a complete history and links to the other subtasks see #421118: [Meta] Standardize capitalization on actions

Problem/Motivation

Lowercase action words are harder to translate. Many contributed modules, like Organic Groups and Views, already use uppercase action words.
To make this task better manageable we decided to split it on a module basis.

Proposed resolution

Change delete to Delete, configure to Configure, view to View, etc.

Remaining tasks

We need a patch for the "add link" module.

Comments

yesct’s picture

Title: [Meta] Standardize capitalization on actions and short sentences [add link] » Standardize capitalization on actions and short sentences [add link]
Status: Needs work » Active
Issue tags: +Novice
beltofte’s picture

Assigned: Unassigned » beltofte
Status: Active » Needs review
StatusFileSize
new660 bytes

Attaching patch for testing.

yesct’s picture

Title: Standardize capitalization on actions and short sentences [add link] » Standardize capitalization on actions 'add link'
Issue tags: +Needs screenshots

Status: Needs review » Needs work

The last submitted patch, 1785006-standardize-capitalization-add-link.patch, failed testing.

beltofte’s picture

Title: Standardize capitalization on actions 'add link' » Standardize capitalization on actions for menu operations: 'add link', 'edit menu', 'delete menu', 'edit', 'delete'
StatusFileSize
new39.26 KB
new103.04 KB

It's from the list of menus in the menu administration. Changing this issue to cover the menu administration.

Menu list before:
1785006 - menu list - before.png

Menu link list before:
1785006 - menu link list - before.png

beltofte’s picture

Status: Needs work » Needs review
StatusFileSize
new2.55 KB
new45.48 KB
new80.49 KB

Updated patch attached.

Menu list after:
1785006 - menu list - after.png

Menu link list after:
1785006 - menu link list - after.png

yesct’s picture

hmm Disable was already capitalized.

beltofte’s picture

Both Disable and Enable are inherited from ConfigEntityListController.php and already capitalized.

Status: Needs review » Needs work
Issue tags: -Usability, -Novice, -Needs screenshots, -ui-pattern, -ui-text

The last submitted patch, 1785006.patch, failed testing.

beltofte’s picture

Status: Needs work » Needs review
Issue tags: +Usability, +Novice, +Needs screenshots, +ui-pattern, +ui-text

#6: 1785006.patch queued for re-testing.

hass’s picture

Status: Needs review » Reviewed & tested by the community
beltofte’s picture

Title: Standardize capitalization on actions for menu operations: 'add link', 'edit menu', 'delete menu', 'edit', 'delete' » Standardize capitalization on actions for menu operations: 'add link', 'edit menu', 'delete menu', 'edit', 'delete', 'reset'
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.72 KB
new124.17 KB
new124.47 KB

Updated patch with missing 'reset' operation + changing brackets in "Parent link" form field (see screenshots).

Parent link options before
1785006 - parent link brackets - before.png

Parent link options after

1785006 - parent link brackets - after.png

yesct’s picture

I think that is the menu name. Is it? Is there always only one in the drop down?

I'm afraid that changes to select are out of scope and will need more discussion. I still think these select changes should be separate issue. At least make a comment on the - None - issue and link here. Also update this issues meta issue to discuss if these sub issues should include changes to select. (I'm on my phone, might be able to do that myself later)

hass’s picture

How about sourounding the menu name with [menu name]?

yesct’s picture

hass’s picture

Let's leave the select change outside for now. It's not a translatable string and this cases are mostly about translatale strings. We can follow up with the select and rtbc the rest for now.

yesct’s picture

Status: Needs review » Needs work

where does reset show in the UI?

needs work to take out the select change.

hass’s picture

If I'm not totally wrong and remember correctly the reset link exists if you move a views menu link to a new position in a menu.

beltofte’s picture

Status: Needs work » Needs review
StatusFileSize
new3.11 KB

Updated patch with the select change reverted.

beltofte’s picture

StatusFileSize
new111.61 KB
new96.01 KB

Reset operation is shown if system menu item has been moved. Lets say that you move admin/structure to admin/content/structure then will Reset be shown, so you can revert this change.

Reset before change:
1785006 - reset - before.png

Reset after change:
1785006 - reset - after.png

yesct’s picture

Status: Needs review » Reviewed & tested by the community

reviewed the code. looks good to me, if testbot agrees.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

yesct’s picture

Issue tags: -Needs screenshots

here is the follow-up #1919258: Remove < and > from menu select for consistency

removing needs screenshot tag.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

clarification