This a subtask of issue 421118 for a complete history and links to the other subtasks see #421118: [Meta] Standardize capitalization on actions
Problem/Motivation
Lowercase action words are harder to translate. Many contributed modules, like Organic Groups and Views, already use uppercase action words.
To make this task better manageable we decided to split it on a module basis.
Proposed resolution
Change delete to Delete, configure to Configure, view to View, etc.
Remaining tasks
We need a patch for the "add link" module.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | 1785006 - reset - after.png | 96.01 KB | beltofte |
| #20 | 1785006 - reset - before.png | 111.61 KB | beltofte |
| #19 | 1785006.patch | 3.11 KB | beltofte |
| #12 | 1785006 - parent link brackets - after.png | 124.47 KB | beltofte |
| #12 | 1785006 - parent link brackets - before.png | 124.17 KB | beltofte |
Comments
Comment #1
yesct commentedComment #2
beltofteAttaching patch for testing.
Comment #3
yesct commenteddoes this go with #1784846: Standardize capitalization on actions in operations in shortcut: 'list links', 'edit set', 'delete set', 'edit, 'delete' ?
where does add link show up? views?
Comment #5
beltofteIt's from the list of menus in the menu administration. Changing this issue to cover the menu administration.
Menu list before:

Menu link list before:

Comment #6
beltofteUpdated patch attached.
Menu list after:

Menu link list after:

Comment #7
yesct commentedhmm Disable was already capitalized.
Comment #8
beltofteBoth Disable and Enable are inherited from ConfigEntityListController.php and already capitalized.
Comment #10
beltofte#6: 1785006.patch queued for re-testing.
Comment #11
hass commentedComment #12
beltofteUpdated patch with missing 'reset' operation + changing brackets in "Parent link" form field (see screenshots).
Parent link options before

Parent link options after

Comment #13
yesct commentedI think that is the menu name. Is it? Is there always only one in the drop down?
I'm afraid that changes to select are out of scope and will need more discussion. I still think these select changes should be separate issue. At least make a comment on the - None - issue and link here. Also update this issues meta issue to discuss if these sub issues should include changes to select. (I'm on my phone, might be able to do that myself later)
Comment #14
hass commentedHow about sourounding the menu name with
[menu name]?Comment #15
yesct commentedNote about changing selects added to #421118-48: [Meta] Standardize capitalization on actions
Comment #16
hass commentedLet's leave the select change outside for now. It's not a translatable string and this cases are mostly about translatale strings. We can follow up with the select and rtbc the rest for now.
Comment #17
yesct commentedwhere does reset show in the UI?
needs work to take out the select change.
Comment #18
hass commentedIf I'm not totally wrong and remember correctly the reset link exists if you move a views menu link to a new position in a menu.
Comment #19
beltofteUpdated patch with the select change reverted.
Comment #20
beltofteReset operation is shown if system menu item has been moved. Lets say that you move admin/structure to admin/content/structure then will Reset be shown, so you can revert this change.
Reset before change:

Reset after change:

Comment #21
yesct commentedreviewed the code. looks good to me, if testbot agrees.
Comment #22
dries commentedCommitted to 8.x. Thanks.
Comment #23
yesct commentedhere is the follow-up #1919258: Remove < and > from menu select for consistency
removing needs screenshot tag.
Comment #24.0
(not verified) commentedclarification