_social_profile_field_get_icon() should use base_path() instead of hardcoding it.

CommentFileSizeAuthor
#2 social_profile_field-1909572-2.patch696 byteschi
#1 social_profile_field-1909572-1.patch443 byteschi

Comments

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new social_profile_field-1909572-1.patch443 bytes
chi’s picture

chi commented
StatusFileSize
new social_profile_field-1909572-2.patch696 bytes

It seems more appropriate to use them_image()

webadpro’s picture

webadpro commented
Status: Needs review » Reviewed & tested by the community

Using theme_image is the proper way to do this.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed

#2 look good for me
commited pushed to 7.x-1.x and tagged 7.x-1.0-beta2 release

thanks!

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Fixed » Closed (fixed)

status