Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Patch includes a new preprocess function for the install page.
Comment | File | Size | Author |
---|---|---|---|
#1 | theme_func_consolidation-1821006-1.patch | 745 bytes | vlad.dancer |
install-page.patch | 620 bytes | EVIIILJ |
Comments
Comment #1
vlad.dancerI have a question! Why just not replace theme_install_page by theme('maintenance_page__install_page')? Is it necessary to use one more func (theme_install_page) just to add http header and call another one?
Here patch that do this staff.
Comment #2
decafdennis CreditAttribution: decafdennis commented@#1: There is room for improvement in a lot of instances, but the goal here is to convert everything to Twig. Not sure if we want to consolidate and refactor at the same time.
Comment #3
jenlampton@naquah we are taking inventory of everything that can/should be consolidated here. I have added this function to the spreadsheet, and opened a issue against suggesting we remove this theme function entirely: #1885714: Remove theme_install_page()
@EVIIILJ patch applies cleanly but the addition of $variables['content'] duplicates the body of the page, since the content is also added by the maintenance page template & preprocess. This feels like a little bit of a hack, but changing theme_hook_original to maintenance page seems to do the trick :)
Committed and pushed to front-end, marking this issue as fixed.