Display a message if there's No Shipping method enabled. [#1720928]

the title says all : #1715126-2: [Revert] Display a message helping the user to configure the shipping methods

Comment	File	Size	Author
#2	no_shipping_method_enabled_message-1720928-2.patch	943 bytes	vasike
#1	no_shipping_method_enabled_message-1720928-1.patch	943 bytes	vasike

Comments

Status	File	Size
new	no_shipping_method_enabled_message-1720928-1.patch	943 bytes

Status	File	Size
new	no_shipping_method_enabled_message-1720928-2.patch	943 bytes

Comment #3

googletorp commented 21 August 2012 at 20:39

Status:

Needs review

» Closed (won't fix)

I don't think it would be a good idea to display a message to the user like this - this is a pure backend message, so it would make more sense to render such a message in the backend. If a message like this should be displayed there should be a permission attached so only admins would see it.

Also you should use the l() function to generate the link instead of writing raw html in drupal_set_message.

Also maybe a shipping pane could be empty because your rule conditions didn't match on the order details - like no shipping outside EU or similar.

Another thing to be aware off is that the shipping pane might not have it's own pane, but be displayed in the order revision page - in that case this message wouldn't make sense at all.

To sum up, I don't see a need for such a message and if we should include it - we need to fund a solutions for all of the above. Figuring out if the shipping pane is on pane for itself is not going to be easy to figure out. If we are able to do this I would rather just redirect to the next or previous step instead of displaying a message.