Authenticated Users Cannot Create BoFs Regardless of Permission Settings

Marking as "active" since there's nothing to review here.

In order to allow to add bof sessions, the following permissions needs to be enabled for Authenticated users:
- Edit own value for field Room
- Edit own value for field Time slot
- Schedule a BoF Session
- View published content

"View published content" has to be explicitly added before you can create a node so I added it in the cod_base.

Works on my end. Patch enables "View published content", "Schedule a BoF Session", "Edit own value for field Room" and "Edit own value for field Time slot" for Auth users. Dunno if it's worth also allowing "Create own value for field Room" and "Create own value for field Time slot" for Auth users. When creating a new bof session "Room" and "Time slot" are not accessible but after successfully creating the node and editing it afterwards, I see those 2 fields available for editing.

Patch works great..it automatically enables the "Views published content" for authenticated users as well as the Schedule a Bof Session, Edit own value for field Time slot and Edit own value for field Room.. yup as what is the comment above..Auth users cannot create room and time slot on bof sessions but they can edit it. Maybe we can make it possible for the auth users to create and edit her own value for field Time slot and field Room.

Patch applied but with whitespace errors:

auth-users-cannot-create-bof-1661620-2.patch:29: trailing whitespace.
auth-users-cannot-create-bof-1661620-2.patch:49: trailing whitespace.
warning: 2 lines add whitespace errors.

Permissions are for cod_session and cod_bof are overridden when I enable the cod_bof Feature after applying the patch.

Patch works but I think I'm missing something here: Wondering why an auth user can set BoF time slot and Room under this model...
- Are BoFs not proposed and moderated just like sessions?
- Shouldn't administrators be setting these values to ensure no topics get double booked? Ex: No one wants 16 cat lover BoF's taking over the entire schedule.

BoFs are submitted by any authenticated user, and are not moderated like sessions.

A user is presented with a list/table of available time slots and rooms, given a 'schedule bof' link in each. This URL sets what time slot/room the BoF is to be scheduled in.

I do not think creating room and time slots are available for authenticated users (unless you explicitly allow them to). The permission here is to edit the existing room and timeslot values if you go directly to node/nid/edit. but if you follow the process, you are able to create the new bof, then go back to program/bofs and schedule your session.

I do agree that there should only be specific room available for bofs but I think this one is out of scope for this ticket.

if anyone can remove the trailing whitespace, that would be great. I already tried editing the source and recreate the patch, manually edit the lines in the patch but nothing changes. not sure what else to do.

hi attach is the patch with out an tariling whitespace.
tested and working on my local

sorry forgot to attach the patch..my mistake here is it now..

patch applied cleanly.

This patch grants "Access content" to authenticated users, but this permission should also be granted to anonymous users by default.

In terms of who should be able to schedule a BoF session, I could see the argument that only registered attendees should be able to schedule BoFs. Is that the DA's intention? If so, seems like this could be the default configuration following #1673036: Add "Attendee" Role.

Yes, the DA's argument is that only registered attendees of the conference can propose/schedule BoFs.

patch - adds the anonymous users to view published content

changing status

#19 patch applies cleanly, but if patch on this issue will make an error, i think it is because of the lines

like on this patch:

diff --git a/cod_base/cod_base.features.user_permission.inc b/cod_base/cod_base.features.user_permission.inc
index a5ac1ca..fa86755 100644
--- a/cod_base/cod_base.features.user_permission.inc
+++ b/cod_base/cod_base.features.user_permission.inc
@@ -10,6 +10,16 @@
 function cod_base_user_default_permissions() {
   $permissions = array();
 
+  // Exported permission: access content.
+  $permissions['access content'] = array(
+    'name' => 'access content',

while on this issue issue:

diff --git a/cod_base/cod_base.features.user_permission.inc b/cod_base/cod_base.features.user_permission.inc
index a5ac1ca..9f95770 100644
--- a/cod_base/cod_base.features.user_permission.inc
+++ b/cod_base/cod_base.features.user_permission.inc
@@ -10,7 +10,7 @@
 function cod_base_user_default_permissions() {
   $permissions = array();
 
-  // Exported permission: access administration pages
+  // Exported permission: access administration pages.

The error is just that it cannot locate the line that is present on the patch.

Patch applies clean.

Does not test out though. Created an user account, they were able to select a time slot/room from the scheduler and save the new node, but it did not save with the selected time/room. User was able to edit and add the room and time slot afterward though.

Auth users are not being granted permission to create their own value for room and time slot.

re-rolled with needed permissions.

As an authenticated user, I can create a node by going to /node/add but I couldn't schedule a bof session. Upon checking, this was forgotten

+  // Exported permission: schedule bof_session.
+  $permissions['schedule bof_session'] = array(
+    'name' => 'schedule bof_session',
+    'roles' => array(
+      0 => 'authenticated user',
+    ),
+    'module' => 'cod_session',
+  );

I couldn't make a clean patch though so I'm just noting it here.

re-rolled the patch with the comment on #24

works as described.

applying this patch puts cod_base into a state of 'Needs Review'.

I went digging into this, starting from #2 changes are being included on cod_base, this patch should only touch cod_bof. Also, this patch deals with field level permissions for time slots and rooms, and based on #1668908: Replace User reference, Nodereference with References, Vertical session schedule view, these fields will be changing to use entity reference. Let's postpone till that issue is resolved.

New issue http://drupal.org/node/1698454

Since I'm already working on bof, I already tested this. Still postponed and need the following issues to be RTBC:
- #1698454: Room and Timeslot permissions
- #1698306: Replace node_reference with entity references in cod_bofs

Once those 2 are resolved, the only thing needed for this to work is:

+  // Exported permission: schedule bof_session.
+  $permissions['schedule bof_session'] = array(
+    'name' => 'schedule bof_session',
+    'roles' => array(
+      0 => 'authenticated user',
+    ),
+    'module' => 'cod_session',
+  );
+

please review

Works on my end. And can schedule a bof session.

works on my end also, patch applies cleanly and i can also schedule a bof session

Should I apply this or #1661614-12: BoF and Sessions Should Not Be Allowed in Overlapping Rooms and Time Slots first? They do conflict with each other.

#1661614: BoF and Sessions Should Not Be Allowed in Overlapping Rooms and Time Slots is RTBC and in the sandbox, this can move forward

Just tested it and it works fine now (no patch needed)

I think you might be working from an out-of-date sandbox, I'm getting an error when applying against the latest version.

i might have. here is the patch that adds field permission level to add room and timeslot for bofs

Looked good, but for some overrides on field permissions in cod_session. This patch should handle those.

Re-roll of patch against 7.x-1.x cod for bofs. should fix this and #1699272: cod_bof view should work with single column sessions schedule and tabs

"FieldException: Cannot change an existing field's type. in field_update_field() (line 234 of myDrupal/modules/field/field.crud.inc)"

Yes - you'll need to do a fresh install to test this. Marking back to needs review.

Since we make changes from node_reference to entityreferences, you must wipe the database and make sure nothing is enabled before you apply the patch. Otherwise it will fail.

I'm somewhat in favor of getting these patches into the core -- then opening new issues based on these patches, because they're all inter-related. (Session migrate, BOF, and Evaluations)

I'm somewhat in favor of getting these patches into the core -- then opening new issues based on these patches, because they're all inter-related. (Session migrate, BOF, and Evaluations)

<bikeshed>Yes we've all been pushing for this for some time (no pun intended). It just so happens that the gestation of such a major architectural change requires multiple rounds of revisions on numerous endpoints. Let's all be patient with the maintainers and reroll whenever necessary. I don't agree that new issues are necessary- there's a lot of work that we've done which should not just be left behind when a simple re-roll is sufficient.

Sorry that these threads have gone on for so long - I'm sure its a lot to onboard oneself. We've all gone through this process when working on Drupal - it is the nature of issue queues I suppose.</bikeshed>

sorry - posted same time as ezra-g

have to apply #1668908: Replace User reference, Nodereference with References, Vertical session schedule view first ;) japerry should have noted this ;)

Applies clean for me, seeing overrides on cod_bof_session

Component: field
            'module' => 'text',
            'type' => 'text_default',
>         ),
>         'listing' => array(
>           'label' => 'above',
>           'type' => 'hidden',
          ),
          'teaser' => array(
            'type' => 'entityreference_label',
            'weight' => 1,
>         ),
>         'listing' => array(
>           'label' => 'above',
>           'type' => 'hidden',
          ),
          'teaser' => array(
            'type' => 'entityreference_label',
            'weight' => 2,
>         ),
>         'listing' => array(
>           'label' => 'above',
>           'type' => 'hidden',
          ),
          'teaser' => array(

A visit to program/bofs shows my rooms and time slots, but that 'authenticated' user is not able to create/schedule a BoF. Checked over the permissions, the 'Schedule a BoF Session' is allowed for the authenticated role, as well as the 'create own value' permission on field_room and field_slot.

So it appears that it is only the link that is missing. Something to do with cod_session_schedule_access ? going to node/add/bof-session I am able to create a bof and assign it to an unused room/time, and it does show up in the schedule. Just unable to track down why I am not being presented with the 'add a bof session' link on program/bofs

Also, when viewing my newly created bof I see an error:

Notice: Undefined property: stdClass::$field_accepted in cod_session_is_accepted() (line 526 of /Users/twardnw/Sites/cod7.dev/sites/all/modules/cod_support/cod_session/cod_session.module).

Well, I guess I should always set up a more realistic test for this. I added a second room, and wow, whaddya know, the schedule(r) works!

im adding a patch to remove the WSOD in #45. This is by no means a solution but Im just providing a cleaner install that might be used to recreate the bof using the new tab display. I think the right ticket for the new tab display is #1699272: cod_bof view should work with single column sessions schedule and tabs

Here are some notes I have:
1. Reverted the patch to use the old views format "Session schedule grid". The quicktab format used in the session views will only work with pre-defined timeslot and room. the bof page dont have them yet and instead we create links for every available room and timeslot so I don't think this format will work for Bofs. #1699272
2. with the recent change in the session tab display, this line was still included $view->cod_schedule_display. Not sure what the plans is for that. this variable is still in use in the tpl file. I just added a value of 0 to simply make it work but it should be removed or updated. #1699272
3. remove the menu hook "program/bofs" because that is using the old session tab solution. I created it by creating a new page in the bof view.
4. There was an agreement here #1698454-2: Room and Timeslot permissions to use "Create value for field Room/Time slot" to allow creation of bof sessions. Some part of the patch were committed in #45 but some part were not -- specifically changes made in the cod_session_schedule_access(). This is added in this patch (for anyone wondering why cod_session code is in the patch)

Marking as a duplicate of #1699272: cod_bof view should work with single column sessions schedule and tabs since these issues share underlying architecture work and are both part of the same goal: Make COD BoF work.