I found the function cod_session_node_view_alter() called both in
cod_session_evaluations.module
cod_session.module
Renamed it to cod_session_evaluations_node_view_alter()
I also found this function cod_session_user_reviewed_session() is using the prefix cod_session instead of cod_session_evaluations but I did not add this in the patch. Is this something we have to change to?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cannot-redeclare-function-1.patch | 2.7 KB | twardnw |
| cannot-redeclare-function-0.patch | 651 bytes | primerg |
Comments
Comment #1
twardnw commentedpatch applies clean, instance of cod_session_node_view_alter() in cod_session_evaluations is renamed properly.
IMO we should modify the other one as well (user_reviewed session), patch attached.
Comment #2
primerg commentedpatch applied cleanly
Comment #3
saltednut#1 applies cleanly with cod_session_node_view_alter() no longer being called twice
Comment #4
greggles#1 applies cleanly but both #1 and the patch in the original post are necessary, right?
Comment #5
saltednutNo it appears that #1 is a continuation of #0.
Note this hunk from #1:
Comment #6
twardnw commentedI rolled the changes done in patch #0 into my patch in #1
Comment #7
ezra-g commentedCould you clarify which single patch is the one we should test or if a new one needs to be rolled?
Comment #8
gregglesIt's #1 and it's good to go.
Comment #9
japerryLooks good!
Comment #10
ezra-g commented#1 is committed. Thanks!
http://drupalcode.org/project/cod_support.git/commit/baf8f10