When using drush makefiles, this file will trigger automatic glip installation by way of drush recursive makefile parsing.
There are 2 patches in this issue:
-One for installing glip in sites/all/modules/git_deploy/glip
-Another for installing glip in sites/all/libraries. It also declares libraries module dependecy, thus triggering its download.
I did two, since it's not clear to me which location is correct and there are unresolved issues with 'libraries' location. Pick only one of them.
I temporary cloned git_deploy repo at https://bitbucket.org/amontero/git_deploy to test it without needing to wait for commit here.
Paste the following in test-git-deploy.make file:
core = 7.x
api = 2
projects[] = drupal
projects[git_deploy][type] = "module"
projects[git_deploy][download][type] = "git"
projects[git_deploy][download][url] = "git@bitbucket.org:amontero/git_deploy.git"
projects[git_deploy][download][branch] = "modules"
I use 'modules' branch here for testing, but you can also test against 'libraries' branch. Thus you can easily test both locations.
To run it, just type "drush make test-git-deploy.make". You will get a fresh Drupal+git_deploy with glip installed for free :)
When other glip version is required, just tweak the glip_deploy.make entries and drush make users will not need to install by hand.
| Comment | File | Size | Author |
|---|---|---|---|
| add-drush-make-file.LIBRARIES.patch | 2.7 KB | amontero |
Comments
Comment #1
amonteroAs seen on #1203134-5: Fix inconsistent location of Glip library
Doh! #1212942: Clean up git_deploy_requirements() tricked me into thinking that still was necessary :(
I'm not sure if it has sense, but maybe a last glip-enabled release is worth and when the no-glip version is done, advance the version number. But I'm not sure if it would shuffle the versions too much or cause compatibility problems. Since there are some outstanding issues with -dev branch, I think it still makes sense, but not sure against what branch/tag. And I also would feel better by not trashing the patch entirely :)
I checked with "drush dl git_deploy --select" and 7.x-1.x-dev is recommended (¿?).
I'm a bit confused, please advise.
TIA.
Comment #2
amonteroAs per #1212942-12: Clean up git_deploy_requirements() I'm in for a 1.x patch. Seems to me that hosting will not have alway available git binaries. Should I rerroll it against 1.x or they can be applied as they are?
Comment #3
darren oh2.x does not use glip.
Comment #4
darren ohThis requires us to have a consistent location for the Glip library, which we do not currently have.
Comment #5
darren ohComment #6
darren ohComment #8
darren ohComment #10
bricas commentedCan we switch the makefile to use https instead of the git protocol for fetching glip? I believe this is more in-line with expected defaults, also the git protocol uses special ports which are not necessarily open on all networks (like ours!).
Thanks in advance.