Refactored display formatter

I would like that first feature you describe, especially adding a CSS class to the currently active day. Will try to test these patches and see how they work.

I thought i commented on this issue and gave a patch...
0001 has been committed, cool!
0002- doesn't consider time format (ampm) display setting - we have this both on the widget and on the formatter level (for some reason...). Could you please add and reroll? thanks.

About the other 2 patches - Could you please add separate issues for these? that way it would be much easier for others to follow and review. Thanks!

Nice patch! shorter, cleaner code.
I couldn't apply the patch with git. Perhaps some problem with -p0 -p1 parameter?
Some things are broken:

 .oh-display-label {
   display: inline-block; /* give each label the same width, to align the hours. */
+  min-width: 11em;
 }

- The day-label-width is moved to css, which is a good thing. But in code an educated guess was made about the width, using $max_label_length. Your patch adds a fixed widht, which generates worse result for short lables. See attached printscreen.
- When one or more day have 'more hours', every day has a is empty 'more hours' displayed. See attached printscreen, left and right column, lower row. With compressed display, output is OK.

+function theme_office_hours_time_range($vars = array()) {
+  $vars += array(
+    'times' => array(
+      'start' => '',
+      'end' => '',
+    ),
+    'format' => 'G:i',
+    'separator' => ' - ',    "<-- new separator??
+  );

- Although the output seems OK, in above function, a new separator is defined. This is confusing. Can't you pass $settings['separator_hours_hours'] ?

- In the third line of the printscreen, the store has 7 open days. However, in column "Hours -grouped, compressed"only 5 are shown. Sat+Sun are not shown. (First-day-of-week was set to Monday).

+.oh-display-grouped  .oh-display-label{
+  min-width: 11em;

- This part comes from your other feature. I think t is missing from this one.

I meant : "I think it (+.oh-display-grouped .oh-display-label) is missing from this patch."

When one or more day have 'more hours', every day has a is empty 'more hours' displayed

This is already happening in current -dev.
There is an error when entering the value 00 vs. ' ' in the widget/node. See attach screendumps.
Perhaps you can find the cause.

See my patch attached.

- I've kept the programmed css-width.I've opened #1614206: How to set the label width correctly?, which you've already read.
- Check _office_hours_field_formatter_defaults(), for the use of array_merge() vs. drupal_array_merge_deep() vs. +
- I've ran the code through Coder, and removed most messages. Drupal doesn't like camelCase.

Here's the patch.

OK, we can put back drupal_array_merge_deep() if/when it has a function;
Shouldn't we move most of office_hours_field_formatter_view() to the theme-function, hence out of the module-file? This makes the .module file lighter.

I understand, that's why i meant move most of office_hours_field_formatter_view(), leaving plm. 15 lines in.

OK.

OK, this is committed, see 25e93f0.

Something is wrong.

On existing installations the widget is fine.
But on a fresh installation (or disable, enable the module) only 1 line of hours is shown.

Try this:
- (re-enable) the module.
- add a OH field
- add/change a node --> only 1 line of hours is shown, without the table-formatting
- now copy version 1.0 of the module in the modules/office_hours/directory.
- refresh all caches on the page (add/change a node), now the widget looks fine.