Closed (fixed)
Project:
Entityqueue
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Apr 2012 at 16:41 UTC
Updated:
10 May 2012 at 21:25 UTC
Jump to comment: Most recent file
By default, there is an entityqueue type for each bundle. As far as I can tell, this is convention only.
Theoretically, this should work.
Also, it suggests that maybe entityqueue_type_get_name() isn't the best named function.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 1524544-13.patch | 4.4 KB | jody lynn |
| #12 | entityqueue-1524544-12.patch | 1.93 KB | tim.plunkett |
| #11 | entityqueue-1524544-10.patch | 2.38 KB | jody lynn |
| #10 | 1524544-10.patch | 2.5 KB | jody lynn |
| #4 | entityqueue-1524544-4.patch | 2.4 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettEr.
Comment #2
jody lynnThis works, and I was able to activate it by running:
drush php-eval "module_load_include('install', 'entityqueue', 'entityqueue'); _entityqueue_create_entityreference_field(_entityqueue_get_target_field_name('foo'), 'entityqueue', 'foo', t('Queue items'), 0);"I could specify the entity/bundle to use on the field settings, but on the entityqueue config itself I could not specify a bundle (since it had no idea of the entity). It works though.
Would be great to have a UI for adding the new bundles as well.
Comment #3
jody lynnAnother problem related to the custom queue not knowing its entity type: when I create a views relationship to a queue the queue choices for my view's entity are not shown as options if those queues are custom bundles.
Comment #4
tim.plunkettNow I'm just making stuff up. But really, it should be possible to have more than one type of node queue, so they can be given different fields. Right?
Comment #5
jody lynnAgree completely. Since the queues are fieldable, the need for additional arbitrary bundles is clear. Will test.
Comment #6
tim.plunkettTo use that last patch, I had a custom module called zed.module:
I then allowed me to select node content types as target types on the creation page, and Views integration worked.
Comment #7
jody lynnThis is an improvement- now the entityqueue UI works right when adding a new queue (lets me pick from the base type's bundles)
However, entityqueue_handler_relationship_entityqueue.inc (options_form) still needs work. It needs to let you choose available queues based on base type not 'type'. Perhaps we need to add a new column for base_type to {entityqueue}.
Comment #8
amateescu commentedThe module has been pretty much rewritten in the 7.x-1.x-ctools branch. The unified queues+subqueues as a single entity type reached it's limits because of limitations from Entity reference.
Things have been split to the familiar structure from Nodequeue, with queues being entity bundles and subqueues being entities with a entity reference field provided by default.
The only thing left to do in the 7.x-1.x-ctools branch in order to bring back the current functionality is to implement the auto-creation of subqueues for the simple queue handler.
Comment #10
jody lynnWe're on the old branch still, using the patch in #4. This additional patch addresses the problem in #7 in terms of expanding this approach for views support.
Comment #11
jody lynnFixing typo in last patch
Comment #12
tim.plunkettediting patches by hand never works.
Comment #13
jody lynnFull current patch off 7.x-1.x