Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Machine name field doesnt appear when content type human-readable name begins with non latin character.
Comment | File | Size | Author |
---|---|---|---|
#33 | 1065626-33.patch | 762 bytes | jibran |
#23 | 1065626-23.patch | 782 bytes | xjm |
#20 | machinename.jpg | 109.76 KB | droplet |
#20 | machine_name.patch | 956 bytes | droplet |
#2 | do1065626-machine-name.patch | 757 bytes | Heine |
Comments
Comment #1
Heine CreditAttribution: Heine commentedIf the entire string is transliterated to the replacement '_', the machinename edit link does not appear.
Attached patch always shows the suffix.
Comment #2
Heine CreditAttribution: Heine commentedWithout tabs.
Comment #3
Heine CreditAttribution: Heine commentedComment #5
Heine CreditAttribution: Heine commented#2: do1065626-machine-name.patch queued for re-testing.
Comment #7
Heine CreditAttribution: Heine commented#2: do1065626-machine-name.patch queued for re-testing.
Comment #8
Heine CreditAttribution: Heine commentedComment #9
Heine CreditAttribution: Heine commented#2: do1065626-machine-name.patch queued for re-testing.
Comment #10
Jeffrey C. CreditAttribution: Jeffrey C. commented#1: do1065626-machine-name.patch queued for re-testing.
Comment #11
Jeffrey C. CreditAttribution: Jeffrey C. commented#2: do1065626-machine-name.patch queued for re-testing.
Comment #12
webchickComment #13
Jeffrey C. CreditAttribution: Jeffrey C. commented#1: do1065626-machine-name.patch queued for re-testing.
Comment #14
Jeffrey C. CreditAttribution: Jeffrey C. commented#2: do1065626-machine-name.patch queued for re-testing.
Comment #15
Heine CreditAttribution: Heine commentedNote that this will not show a transliteration. It will show the machine name edit link all the time, to allow one to set the machine name manually.
Comment #16
Jeffrey C. CreditAttribution: Jeffrey C. commentedSorry, but is this fix available for Drupal 7.x? And by the way, what's the difference between the two patches you provided? (759 bytes and 757 bytes?)
Comment #17
Heine CreditAttribution: Heine commented#1 contained a tab instead of spaces (as indicated in #2).
The patch applies to Drupal 7.x-dev with a slight offset.
Comment #18
Heine CreditAttribution: Heine commentedPatch still applies to D8.
Comment #19
franzPatch seems fine, I think we need manual testing here.
Comment #20
droplet CreditAttribution: droplet commentedWhy not expand it directly.
Show my idea only, JS code needs improves.
- Show edit button:
user may leave as it (think that system use default value), so gets error.
- Show inputs "*" (Mandatory field)
empty value, they try to type in something.
Comment #21
xjmThis has pretty serious implications for sites using non-unicode character sets (see discussion in #1164812: Improve UX for machine names for fields.), so increasing the priority.
Comment #22
xjmI'm not sure about the UX for #20. This patch causes the cursor to jump unexpectedly from the label field to the newly-revealed machine name field when you enter a non-alphanumeric character in the label field, which is weird.
Comment #23
xjmAttached is just a reroll of #2. I think this is actually the preferable behavior.
Comment #24
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedYeah ... this would do.
Comment #25
droplet CreditAttribution: droplet commented@#22,
"cursor to jump..." can be fix. I will create a new thread for #20.
Thanks :)
Comment #26
Niklas Fiekas CreditAttribution: Niklas Fiekas commenteddroplet: Thanks, can you link that one here? It's good to have it seperated, because there might be alternatives, like a magically improved transliteration.
Comment #27
xjmAnd it's been tested, so untagging.
Comment #28
xjmSee also:
Comment #29
droplet CreditAttribution: droplet commented@#26,
see:
#1447860: Show machine name input if every character is replaced
Comment #30
catchThanks! Committed/pushed to 8.x, moving to 7.x for backport.
Comment #31
catchla la la
Comment #32
catchShould be a straightforward backport, tagging novice.
Comment #33
jibranpatch for 7.x
Comment #34
jibranComment #35
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedThank you.
Comment #36
xjmTag stays on. :) Thanks!
Comment #37
klonosThis works just fine for me in latest D7 dev. The sooner we get this in, the sooner something can be done in contrib to also provide a transliterated machine name: #1436596: Support transliteration of machine names
Comment #38
webchickCommitted and pushed to 7.x. Thanks!
Comment #39
klonosThanx Angie ;)
Comment #40
droplet CreditAttribution: droplet commented@#26 Niklas Fiekas ,
#1447860: Show machine name input if every character is replaced
Comment #42
webchickx