Machine name field doesnt appear when content type human-readable name begins with non latin character.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Heine’s picture

Title: Human-readable content type name begins with non latin character - no machine name dialog. » Machine name not editable if every character is replaced.
FileSize
759 bytes

If the entire string is transliterated to the replacement '_', the machinename edit link does not appear.

лллллллллллллллллллл -> no edit link
ллллллллллллллллллллa -> machinename appears

Attached patch always shows the suffix.

Heine’s picture

Issue tags: -category
FileSize
757 bytes

Without tabs.

Heine’s picture

Version: 7.0 » 7.x-dev
Component: ajax system » javascript
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, do1065626-machine-name.patch, failed testing.

Heine’s picture

Status: Needs work » Needs review

#2: do1065626-machine-name.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, do1065626-machine-name.patch, failed testing.

Heine’s picture

Status: Needs work » Needs review

#2: do1065626-machine-name.patch queued for re-testing.

Heine’s picture

Version: 7.x-dev » 8.x-dev
Heine’s picture

#2: do1065626-machine-name.patch queued for re-testing.

Jeffrey C.’s picture

#1: do1065626-machine-name.patch queued for re-testing.

Jeffrey C.’s picture

#2: do1065626-machine-name.patch queued for re-testing.

webchick’s picture

Issue tags: +Needs backport to D7
Jeffrey C.’s picture

Issue tags: -Needs backport to D7

#1: do1065626-machine-name.patch queued for re-testing.

Jeffrey C.’s picture

Issue tags: +Needs backport to D7

#2: do1065626-machine-name.patch queued for re-testing.

Heine’s picture

Note that this will not show a transliteration. It will show the machine name edit link all the time, to allow one to set the machine name manually.

Jeffrey C.’s picture

Sorry, but is this fix available for Drupal 7.x? And by the way, what's the difference between the two patches you provided? (759 bytes and 757 bytes?)

Heine’s picture

#1 contained a tab instead of spaces (as indicated in #2).

The patch applies to Drupal 7.x-dev with a slight offset.

Heine’s picture

Patch still applies to D8.

franz’s picture

Issue tags: +Needs manual testing

Patch seems fine, I think we need manual testing here.

droplet’s picture

Issue tags: +Needs usability review
FileSize
956 bytes
109.76 KB

Why not expand it directly.

machine name

Show my idea only, JS code needs improves.

- Show edit button:
user may leave as it (think that system use default value), so gets error.

- Show inputs "*" (Mandatory field)
empty value, they try to type in something.

xjm’s picture

Priority: Normal » Major

This has pretty serious implications for sites using non-unicode character sets (see discussion in #1164812: Improve UX for machine names for fields.), so increasing the priority.

xjm’s picture

I'm not sure about the UX for #20. This patch causes the cursor to jump unexpectedly from the label field to the newly-revealed machine name field when you enter a non-alphanumeric character in the label field, which is weird.

xjm’s picture

FileSize
782 bytes

Attached is just a reroll of #2. I think this is actually the preferable behavior.

Niklas Fiekas’s picture

Status: Needs review » Reviewed & tested by the community

Yeah ... this would do.

droplet’s picture

Issue tags: -Needs usability review

@#22,

"cursor to jump..." can be fix. I will create a new thread for #20.

Thanks :)

Niklas Fiekas’s picture

droplet: Thanks, can you link that one here? It's good to have it seperated, because there might be alternatives, like a magically improved transliteration.

xjm’s picture

Issue tags: -Needs manual testing

And it's been tested, so untagging.

droplet’s picture

catch’s picture

Status: Reviewed & tested by the community » Fixed

Thanks! Committed/pushed to 8.x, moving to 7.x for backport.

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

la la la

catch’s picture

Issue tags: +Novice

Should be a straightforward backport, tagging novice.

jibran’s picture

Status: Patch (to be ported) » Needs review
Issue tags: -Novice, -Needs backport to D7 +category
FileSize
762 bytes

patch for 7.x

jibran’s picture

Issue tags: -category
Niklas Fiekas’s picture

Status: Needs review » Reviewed & tested by the community

Thank you.

xjm’s picture

Issue tags: +Needs backport to D7

Tag stays on. :) Thanks!

klonos’s picture

This works just fine for me in latest D7 dev. The sooner we get this in, the sooner something can be done in contrib to also provide a transliterated machine name: #1436596: Support transliteration of machine names

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

klonos’s picture

Thanx Angie ;)

droplet’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

webchick’s picture

Issue tags: +7.13 release notes

x