I think the steps are
1. deploy the code
2. update http://drupal.org/node/101497
3. Update our internal e-mail templates

I can definitely do 2 or 3. It would be ideal, IMO, to do #1 at Badcamp.

Comments

dww’s picture

The main technical question around doing this for sec.d.o is if we use tracker2 there. If not, we actually need to do some more work first. In particular:
#1284726: Teach project_issue views about flagged nodes for following issues

Currently, it all works on d.o b/c we use tracker2. The issue views use tracker2 b/c of #921210: Fix performance of "My issues" and then the follow flag stuff interacts with tracker2's DB tables b/c of #404084: Add support for tracking flagged nodes. But, without tracker2, although the follow UI itself would work, and would impact the e-mail notifications, the tracker and "My issues" pages wouldn't show you the nodes you're following...

If sec.d.o is not running tracker2, we can either:
A) Deploy/enable tracker2 on sec.d.o
B) Fix #1284726 (should only be ~1 hour of total work
C) Live without this so that "My issues" on sec.d.o doesn't show you stuff you're following

greggles’s picture

A seems fine to me, just needs confirmation that tracker2 respects node access. C also seems fine to me. B seems fine but I don't like the idea of suggesting more work for someone else ;)

dww’s picture

B needs to happen sooner or later. ;) C seems like an unfortunate compromise. I'm okay with A if we just want this done ASAP with no additional dependencies on me.

dww’s picture

I think more stuff from Expand "follow" functionality on Drupal.org should be completed before another point release, especially this:

#1284726: Teach project_issue views about flagged nodes for following issues

But also these:

#1310884: Per-project e-mail subscribe page is confusing since it defaults to 'None' when the user has no preference
#1304550: Display count of issue followers when viewing an issue

But, then again, what's in Git right now has been happily running on d.o for months. There's always alpha7. ;) However, I think releasing alpha6 without #1284726 would be a pretty serious WTF, so I'd rather not go there.

If someone else has time to test and verify that tracker2 respects node access, I can set aside some time in the next couple of weeks to help out with the upgrade and deployment (assuming you're willing to run 6.x-1.x-dev, like we do on d.o). I'm less able (at least right now) to volunteer to finish up #1284726 and alpha6. Ask me again once http://drupal.org/community-initiatives/drupalorg/distribution-packaging is done. ;)

Cheers,
-Derek

mlhess’s picture

Issue summary: View changes
Status: Active » Fixed

This works with issue notifications in 7.x. Marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.