Invoke hook_project_release_create_package() when a package is being created

Seems to make more sense to me to add this as a Project release hook in package_releases(). Could you roll a patch for package-release-nodes.php?

I hate to slow the momentum here, but shouldn't this new hook be documented in project.api.php?

Here's a start:

/**
 * Respond when a project release node is packaged.
 *
 * @param $shortname
 *   The shortname of the project.
 * @param $release_node
 *   The node object of the project release.
 */
function hook_project_release_create_package($shortname, $release_node) {
  // This is purely a notification hook, implementations will vary from use
  // case to use case.
}

Thanks for the patches here. I'm totally down with invoking a hook at this point.

However, any reason not to just pass in the fully-loaded project node as the first argument? Your use-case might only care about the shortname, but I can certainly imagine needing to at least know the project nid, if not all sorts of other things about the project, if I was watching this hook...

Cheers,
-Derek

Perfect. I just wanted to ask instead of changing it myself since I know this change will require a change over at project_dependencies.

I fixed the code style on the PHPDoc block, then committed and pushed:

http://drupal.org/commitlog/commit/122/297dd4494600141f272aa01ad2208b51f...

Thanks!
-Derek

The last patch has a bug: if a project is not explicitly provided on the command line, $project_node is not going to be initialized, as debugged by jthorson (++) in #1241704-25: Deploy Project Dependency, Project and PIFT on d.o.

Patch attached for review.

Committed.

Now deployed.

Please remove the "needs drupal.org deployment" tag once things are actually deployed.

Thanks,
-Derek