SQL Error in All Participants

I'm unable to recreate this. Have you run update.php? Can you recreate this using the view provided with the Amazon Example feature and adding "all participants" to it? This also could be related to a specific ASIN you're using - perhaps you can figure that out.

Perhaps you could attach an export of the view you're using (or a feature (see Features module), if it's not based on the example view + content type)

Attached is a screenshot of a working view.

Sorry, you'll have to include the content type in the feature; I can't use this as it is.

If you could also provide at least a few of the ASINs that you're using, that would be useful, since it may be related to the ASIN you're using.

If you want to provide me a database, you can attach the database dump or send it to me or send me a dropbox link - randy at randyfay.com

Sorry, your view doesn't have any fields and doesn't have the relationship that would be required.

Could you please start with the Amazon Example view and demonstrate this problem using that? Documentation on how to create a view and the necessary relationships is at http://drupal.org/node/595464

I've attached a screenshot of what your view looks like.

Hmm. Well, that's what I did originally, and it worked fine. I just did it again, making sure I had at least one of your examples. See the attached.

Are you using a recent version of views? Have you run update.php? Can you recreate this problem on a fresh install?

Well, send me the database of the clean install you did. See #4.

Installed your database. Added a field to the view. Worked fine. Result is attached.

What version of mysql are you using, and on what platform?

BTW, the detailpageurl thing is something we've spent a lot of time on but haven't successfully nailed. Not related.

When you select "All participants", it then gives the option of not showing all participants. At each point I've been just keeping the default "all participants". Is that the same as what you're doing?

Aha! My sandbox hadn't had a views update for awhile. With the views update, I get the error! Yay.

This is the code that fails:

  function pre_render($values) {
    $this->field_alias = $this->aliases['asin'];
    $this->items = array();

    $asins = array();
    foreach ($values as $result) {
      $asin = $this->get_value($result);
      if (!empty($asin)) {
        $asins[] = $asin;
      }
    }

    $query = db_select('amazon_item_participant', 'aip')
      ->condition('asin', $asins, 'IN');

    if ($this->options['participant_type'] != '**ALL**') {
      $query = $query->condition('type', $this->options['participant_type']);
    }
    $query->fields('aip', array('participant', 'asin'));

    $results = $query->execute();

    while ($record = $results->fetchAssoc()) {
      $this->items[$record['asin']][] = check_plain($record['participant']);
    }
  }

The reason it fails is that

      $asin = $this->get_value($result);

returns array(0).

So something has shifted again in how Views does these things. I'll ask dereine for the magic incantation.

See #1145770-12: Helper function for getting raw and rendered field data

I ran into this today also. Glad to see that someone is already on it.

Conversation with merlinofchaos:

<merlinofchaos> rfay: Replace $this->get_value() with parent::get_value() -- that's the quick fix.
Oh wait
<merlinofchaos> Add TRUE as a 3rd arg to get_value
<merlinofchaos> $this->get_value($result, NULL, TRUE)
<merlinofchaos> Does basically the same thing.

<merlinofchaos> rfay: So the longer fix is actually that you would serve your userbase well if you updated the list to allow advanced rendering.

<merlinofchaos> To do that, you need to 1) look at the prerender_list handler. To work with advanced rendering, it needs a 'render_item' method. For backward compatibility, we didn't *require* allowing this.
* dmitrig01 (~dmitrig01@drupal.org/user/47566/view) has joined #drupal-views
* dmitrig01 has quit (Client Quit)
<merlinofchaos> Allowing advanced rendering means that rewrites will happen per each item in the list, rather than on the whole set.
<rfay> merlinofchaos, can you point me to an example that does something similar?
<merlinofchaos> rfay: user roles
<merlinofchaos> rfay: What's awesome here is that you'll implement a render_item method that probably is a one liner
<merlinofchaos> And then you'll eliminate some code from your prerender
<merlinofchaos> rfay: And if there's subsidiary data that's not normally available, you can make it available as 'self tokens'
<rfay> OK, cool.
<rfay> "Self tokens"!
<merlinofchaos> rfay: Yeah. What it means is that you fill $this->items with arrays of data, rather than rendered data
<merlinofchaos> And when they rewrite, they can use the tokens that you provide.
<merlinofchaos> So like the user roles one allows the role name and the rid as tokens

<rfay> merlinofchaos, sadly, neither of the quick fixes seems to get me out of hell. The 3-arg get_value() and the parent::get_value() both leave me with the same #fail. 
<merlinofchaos> ...it should absolutely not return an array in that case, though.

Unfortunately, I tried the two quick fixes with no luck.

I haven't gotten back to it, but #23 has the blueprint. Patches are welcome.

I started a patch for this today. So far, I've eliminated the SQL error and am getting the names of the participants appearing in Views. I still have yet to test the tokens things that merlin described.

No more time to work on it today, but I just wanted to post the status so somebody else doesn't waste their time duplicating the work in the mean time. Should be ready tomorrow (unless something comes up that keeps me from it). If the token thing doesn't work, I'll probably post the patch without it, since it doesn't seem to be something necessary but additional functionality that the other field handlers in this module may not have either.

Great! You can assign it to yourself in that case... Thanks for your effort!

Here's the patch to fix the error and show All Participants in views. I think merlin was speaking in general about reducing the code in pre_render, because there's not a lot there. At least not any more than for user roles. I added a conditional check but there was nothing I could see that could be removed.

This also includes the self tokens. I set it to have name and type as self tokens. Technically, I think that could be considered adding a feature, but it's a fairly small change, so I included it with the bug fix. If I need to split it into seperate patches, I can do that.

I didn't find a lot of info on self tokens, but it appears you can use them in the "rewrite results" for the field itself. You cant' use them as tokens in other fields.

Wow, it applies, it works on a casual test! Thanks for the great work.

I would appreciate if you'd take the tokens out and add a new feature request that does all the views fields; It doesn't seem to make sense to do it just here right now - I'm sure open to having them everywhere. And, of course, we have an issue open about adding token support back in.

And @dereine says it looks fine! So wow, congratulations, and thanks.

No problem, but after further looking over views handlers, I don't think the change for the self tokens would be applicable to any of this module's fields but this one. The only fields that use it in Views are the ones that extend views_handler_field_prerender_list.

Also, it appears Views employs its own token system that's unrelated to the other Token issue, which doesn't affect the views field handler. All the fields currently have functional Views tokens. They don't need any changes.

Do you still want me to open a separate issue for it, since it would only apply to this field?

@cristinawithout, if you think this is an appropriate feature addition, and that it only goes with this field, I'm OK with it. Thanks!

Cool. I did a double check and confirmed the only views handlers using self tokens are those extending views_handler_field_prerender_list. So it doesn't apply to the rest of the fields.

For use reference, an example for self tokens would be if you want to not just display the name of the participant, but the participant type (author, actor, etc).

• Add the field "Amazon: All participants".
• Under "Rewrite Results", check "Rewrite the output of this field", then enter something like "[participants_all-name]: [participants_all-type]".

For ASIN B004QOB8QG the output for "[participants_all-name]: [participants_all-type]" would look like:

Matt Smith: actor, Karen Gillan: actor

Or setting the rewrite to "[participants_all-name] ([participants_all-type])" would look like:

Matt Smith (actor), Karen Gillan (actor)

I am just waiting for one of the users who was bothered by this to test and RTBC it :-)

Committed: b9ce422

Would appreciate if you could document the self-tokens by adding a little note to the documentation page

You are very welcome here. Thanks so much for taking this one on.

If you use Amazon module and would be interested in becoming a comaintainer, please let me know. It's pretty easy to arrange :-)