The Content-Type header is incorrectly parsed in SmtpMailSystem::mail() function. [#1199966]

Comment	File	Size	Author
#6	content-type-parsing-1199966-6.patch	2.21 KB	fabianx
#1	content-type-parsing-1199966-1.patch	2.59 KB	pillarsdotnet

Comment #1

pillarsdotnet commented 25 June 2011 at 16:51

Status:

Active

» Needs review

Status	File	Size
new	content-type-parsing-1199966-1.patch	2.59 KB

This patch allows SMTP, HTML Mail, and Mail System to work together.

Log in or register to post comments

Comment #2

pillarsdotnet commented 26 June 2011 at 02:29

Created a documentation page illustrating the use-case that makes the above patch necessary.

Log in or register to post comments

Comment #3

pillarsdotnet commented 28 June 2011 at 17:14

Also, it would be lovely if the SMTP developers would contribute to the documentation here.

Log in or register to post comments

Comment #4

fabianx commented 11 November 2011 at 17:50

Status:

Needs review

» Reviewed & tested by the community

Reviewed and tested, but the middle part of the patch will conflict with #1330714: Character encoding conflict between Drupal and phpmailer., which when applied will solve this issue more elegant.

Why this patch works:

Content-Type can be setup like "text/plain; foo/bar", but it can also be "text/plain;foo/bar". The space is not a must and such should not be accounted for.

The patch also improves the error message by saying, which header could not be analyzed. This will help in debugging.

Please apply.