admin/structure/block/add shows "Blocks" as page title, instead of "Add block".
The inherit-page-title-from-active-trail code contains an explicit condition to ignore local tasks in the active trail.
I wonder why that special-case exists at all.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | local-action-title-996302-21.patch | 670 bytes | berliner |
| #20 | local-action-title-996302-20.patch | 490 bytes | David_Rothstein |
| #15 | drupal8.menu-local-task-page-title.15.patch | 8.45 KB | sun |
| #12 | drupal8.menu-local-task-page-title.12.patch | 8.28 KB | sun |
| #8 | drupal8.menu-local-task-page-title.8.patch | 498 bytes | sun |
Comments
Comment #2
sunActually, the test results are awesome. At least the menu breadcrumbs are testing the current oddity of NOT showing the local task title, which obviously needs to be corrected with this patch.
Comment #3
hefox commentedTried this patch to fix issue where the a set of pages defined as base/*, base/*/local_task, base/*/local_task2, and base/*/local_action were always showing 'Home' cause it didn't pick up any of the local tasks, and it fixed that, however actions look a bit confused.
On a different path (add term to tags).
Pre patch
Post Patch
Both aren't ideal; the former doesn't contain add term, the later doesn't contain vocabulary name (other than via the breadcrumb). I'm not sure if it's suppose to be different and it does fix the issue I have on the original patch (other than the action task is generally confusing lack of what it's an action to).
Comment #4
sun@hefox: That's a separate issue. The menu system can only output what has been defined. If the "Add term" (local action) page defines a static title, then a static title is output. However, you also need to know that the menu system currently does not have a separation for menu link titles and page titles, so if you'd change the link title to be dynamic (e.g., "Add term to Tags"), then you'd see that title as label for the local action (on the overview page) as well as a page title on the page itself. In such cases, the only existing workaround is to manually use drupal_set_title() to set a dynamic page title. But obviously, that kind of problem only applies to dynamic local tasks/actions that belong to dynamic parent items/entities in the first place. There are many local tasks/actions that are used within a static context.
Comment #5
jbrown commentedSee also: #983294: Breadcrumbs are not consistent for tabs on the same page.
Comment #6
sun@hefox' suggestion in #3 is somewhat in line with the change proposed #111081: Output title of current local task in HEAD title (e.g., "People » List")
Discussed with @merlinofchaos in IRC, and we think that the UX team should have a stab on the problem space first.
The original idea kinda was that breadcrumb, page title, and tabs together form the "page context".
With this patch, the title of a local task, say "Edit", would appear in a tab, and also in the page title. Sorta "duplication", but possibly not really, since users might primarily look at the page title; ignoring tabs and breadcrumb.
Comment #7
Bojhan commentedI think this would be a good improvement, however could we have a few more examples to build a picture of the impact of this patch? The duplication is not really a problem, since it is a important signifier on the page.
Comment #8
sunComment #9
Bojhan commentedI have just reviewed this. But I am a bit confused because for example menu/manage/management/edit has the label management and something like config/media/image-styles/edit/medium has Edit medium style. Although the last seems the favorable standard, I do not see it anywhere else.
Comment #11
Bojhan commentedSee question above
Comment #12
sunRe-rolled against latest branch HEAD.
Test should pass with attached patch.
I'm not sure what's going on with the page title on administration pages for system menus; e.g.,
admin/structure/menu/manage/navigation/addshould normally show "Add link"but it shows "Navigation"
However, it works correctly for menus that are not system menus; e.g., with Devel installed,
admin/structure/menu/manage/devel/addcorrectly shows "Add link"Comment #13
sun#12: drupal8.menu-local-task-page-title.12.patch queued for re-testing.
Comment #15
sunRe-rolled against HEAD.
Comment #18
dawehnerGiven that the page title and the tab title is now 100% separated this issue does not make sense, beside maybe d7.
Comment #19
sunYes, I assume/hope this is obsolete now. Can't be changed for D7, because it's a major API/UI change.
Comment #20
David_Rothstein commentedAs titled I think this is a won't fix for Drupal 7, but the original issue wasn't about local tasks in general, it was about local actions:
I think for local actions this is a legitimate bug. The words "Add block" literally appear nowhere on the page right now, so it's not even clear what the action you're performing is. (At least for other local tasks, e.g. "Edit", the action you're performing appears as the highlighted tab.)
Here's a patch that just fixes local actions. I assume it will break some tests, but the real question is whether it breaks any important assumptions other code out there is making.
Comment #21
berliner commentedThe last patch for D7 doesn't apply to the current dev version anymore, so here is a new one doing exactly the same thing.
I haven't looked into any repercussions either.
Comment #23
berliner commentedNot sure why this fails, the test results look good: https://dispatcher.drupalci.org/job/drupal_d7/98159/testReport/
This was also reported in #891892: Page/Overlay title doesn't change when MENU_LOCAL_ACTION is used