Setting the dom_id from within the style plugin proved to be very useful to fullcalendar, but to do that it needed to use something like views-dom-id-fullcalendar-1, which got killed off by the intval() in includes/ajax.inc.

Replacing that with a preg_replace() will make everything work while still sanitizing the id.

CommentFileSizeAuthor
#1 views-1147234-1.patch763 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new views-1147234-1.patch763 bytes

See patch.

geerlingguy’s picture

geerlingguy commented

Patch applied cleanly for me, and also allows #971034: Add Option To Load Events Via Ajax to work. I hate regex, so someone else can approve that.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

[^a-zA-Z0-9_-]+ matches all characters that aren't letters, numbers, - or _. Then it replaces them with -.

Normal "machine names" don't allow dashes, just underscore, but these are HTML classes, so dash is equally if not more valid.

aspilicious’s picture

aspilicious commented

subscribe

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

This patch makes totally sense. Commited to both 3.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.