Repeatable sequence:
Orders > Create Order
E-mail: user+test@gmail.com
"Invalid e-mail address.
Use this account now?
User 14 - user test@gmail.com"
Apply
"Primary e-mail: user test@gmail.com"
Which is not what was entered and does not follow email standards. See http://en.wikipedia.org/wiki/Email_address#Address_tags and http://tools.ietf.org/html/rfc3696
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 975194-create-order.patch | 7.23 KB | longwave |
| #13 | 975194-create-order-email.patch | 3.93 KB | Island Usurper |
| #12 | 975194-create-order-email.patch | 5.16 KB | Island Usurper |
| #4 | 975194-create-order-email.patch | 4.88 KB | longwave |
Comments
Comment #1
tr commentedPlease test the -dev version of Ubercart to see if this is still a problem.
Comment #2
todd zebert commentedI installed the 2010-Nov-17 DEV, ran update, and repeated the test: same incorrect handling.
Comment #3
tr commentedComment #4
longwaveThe customer search form sends the field values as arguments in a URL, but when doing this, any plus symbols get decoded to spaces by the web server (this is by design, see RFC 2396 appendix G.2).
The attached patch fixes this by POSTing the search parameters, for both the existing customer and new customer forms, and it also correctly escapes the supplied data in the resulting SQL query.
Comment #5
todd zebert commentedI applied the patch using UC 2.x-Dev 2010-Nov-28.
Retested as above, and moved past the last error, so I progressed:
I checked "E-mail customer account details."
Create order
Added some billing info, products, comments, save changes
Invoice > mail invoice > mail invoice
I received both emails "An administrator created an account for you" and "Your Order Invoice"
It seems to be working perfectly. Thanks!
Comment #6
todd zebert commentedWill this get reviewed and placed into Dev?
Comment #7
todd zebert commentedIt's NOT in Dev as of 6.x-2.x-dev (2010-Dec-10)
What should my expectation be for timing?
Thanks!!
Comment #8
todd zebert commentedpatched successfully against 6.x-2.x-dev (2010-Dec-10) and testing working.
Comment #9
Island Usurper commentedThanks for the review, Todd. Sorry about the delay.
Committed.
Comment #10
todd zebert commentedThanks @Island Usurper, no worries, I'm just learning how to help with the issue queue.
I retested as above using Ubercart 6.x-2.x-dev (2011-Jan-21) and it worked.
Thanks!
Comment #11
longwaveNeeds porting to 7.x.
Comment #12
Island Usurper commentedPatch for Drupal 7.
Comment #13
Island Usurper commentedOops. Too much included in that patch.
Comment #14
longwaveUpdated patch attached that includes #13 and also fixes the search customer/create order functionality so it works properly in D7.
This feature should probably all be moved over to full AJAX functionality, but I didn't have time to change all that.
Comment #15
longwaveCommitted #14.
Comment #16
tr commentedI think the issue from #903292: problems with wildcards in customer search needs to be addressed in these patches ...
Comment #17
longwaveThat issue is related to the customers page, this is the separate search facility on the new/edit order pages. Wildcard searches work for me, but reopen if you find problems.