There's a start with VersioncontrolRepositoryUnitTestingTestCase, but that needs expansion to do more than just CRUD (and to really do all CRUD, well), AND exercise the various additional methods we have/want on a VersioncontrolRepository object.
Then, we need to write similarly complete tests for all of our entities. Probably best to do these all in one fell swoop - will be faster to do and more consistent that way. This could reasonably be broken out into separate issues for each of the tests, but this can act as a meta-issue for that for now.
Comments
Comment #1
sdboyer commentedNote that these should all use the framework introduced in #960406: Introduce new testing framework, and do as much in VersioncontrolTestCase::BACKENDS_ALL mode as possible.
Comment #2
marvil07 commentedPostponing until #879858: Unify entity C(R)UD gets in since IMHO it would be easier to do this after.
Comment #3
marvil07 commentedupdate: bad issue
Comment #4
marvil07 commentedsorry, I wrote a comment and changed status by error in the bad issue, so, re-opening and moving to right tags
Comment #5
sdboyer commentedFor historical accuracy of the backlog, it's important that we maintain all the tags for all the sprints in which we ever thought we'd do this.
Comment #6
marvil07 commentedComment #7
sdboyer commentedOK, here's a set of guidelines I think CRUD tests should strive for, in descending order of importance.
$query->condition($alias . $field_name, $value)), and then additional checks for any sort of condition that follows an alternate path.VersioncontrolEntity::cacheGetgenerally makes me think we could see a fair number of those, and that's potentially really bad.