Documentation how to use ctools modal dialog for file uploads

Removed one more line:

  var object = $(this);
  try {
    url.replace('/nojs/', '/ajax/');
    var ajaxSettings = {};
    if ($(this).attr('enctype') == 'multipart/form-data') {
      url = url + '?ctools_multipart=1';
      ajaxSettings.success = Drupal.CTools.AJAX.iFrameJsonRespond;
      ajaxSettings.iframe = true;
    }
    else {
      ajaxSettings.success = Drupal.CTools.AJAX.respond;
      ajaxSettings.iframe = false;
    }
    $(this).ajaxSubmit({
      type: "POST",
      url: url,
      data: '',
      global: true,
      error: function() { 
	      alert("An error occurred while attempting to process " + url); 
	    },
      complete: function() {
        object.removeClass('ctools-ajaxing');
        $('.ctools-ajaxing', object).removeClass('ctools-ajaxing');
      },
      dataType: 'json',
    } + ajaxSettings);
  }

Here's an updated patch. The original patch made some changes that I didn't like, plus actually could introduce bugs (introducing a new variable without using 'var' explodes on some browsers, for example).

It directly added "?" to the URL which breaks when clean URLs are off, so I moved the component to the data, which means that it now checks $_REQUEST. I believe these items should be merged properly.

I didn't test a file upload; the test included modified the 'custom' type which I didn't want to accidentally commit, so I did not patch that part. So I'm putting the patch here in the hopes that someone else will test this and make sure it continues to work.

Whoops, last patch contained a leftover debug msg.

Well, I went ahead and committed htis.

I think we were rolling a little loose with adding objects (was seeing ajaxOptions contain two objects) and was seeing the page hang when trying to upload files.

      ajaxOptions = {
        success: Drupal.CTools.AJAX.iFrameJsonRespond,
        iframe: true,
        data: {'ctools_multipart': '1'}
      } + ajaxOptions;

I renamed the additive object and added a call to Jquery.extend to the end which got it working for me.

       jQuery.extend(ajaxOptions, ajaxIframeOptions);

I had totally missed that htis had a new patch. Josh, can you confirm for me that populist's patch works?

the new version of ctools broke the passing of data through the data attribute of the ajax submit options. the ctools_multipart variable previous defined (see below) is nowhere to be seen in ctools_ajax_render().

ajaxIframeOptions = {
         success: Drupal.CTools.AJAX.iFrameJsonRespond,
         iframe: true,
        data: {'ctools_multipart': '1'}
}

my solution is to pass back the ctools_multipart value using that same form (which ctools_ajax_render()) like so:

$(this).append('<input type="hidden" name="ctools_multipart" value="1">');

i rerolled my old patch (which is still necessary to merge the javascript objects) and posted it all together. works in my two test cases.

I think the file upload issue was solved in CCK using this in the AHAH callback:

  // Using drupal_json() breaks filefield's file upload, because the jQuery
  // Form plugin handles file uploads in a way that is not compatible with
  // 'text/javascript' response type.
  $GLOBALS['devel_shutdown'] =  FALSE;
  print drupal_to_js(array('status' => TRUE, 'data' => $output));
  exit;

Note that this also disables devel_shutdown.

If populist's patch needs to get in, then I would suggest using $.extend() rather than jQuery.extend().

Committed, with the $.extend change.

#13 suggests I committed this, so 'needs work' is wrong status.

Can anybody confirm this is working for him in IE Browsers? I cant. Simple "only one file" upload method, wont work.
Not work is probably the wrong description. The file gets uploaded, but the request result is somehow a unknown filetype for the IE ( unkown Mime ) instead of being json.

Bit of researching told be that it is quiet a bad idea calling form.submit() in a IE, because this will include other security checks, making those json call fail.

I expect this http://drupal.org/node/947532 to be a similar issue or rather the same

well finally gound out that it all comes down to a missing

form['#attributes']['enctype'] = 'multipart/form-data';

See the other issue for detailed explaination. Should we include that in the ctools docs somehow? Debugging this is a reayl painfull work...

That's actually a general form api issue. You can't upload files to forms, CTools or not, without that. Perhaps this could be stressed in the CTools documentation, but I'm not certain where.

@EugenMayer,
There's an example module I did that uses CTools' ajax for file upload in #940286: Code example for "File" form element in ajax form, that might help you.

you can upload files without setting this @merlin, it actually really affects the ajax part right now, due the jquery selector.
@19 well its fixed for me already, i was just thinking about saving other peoples time searching for this.

fyi, I have stumbled upon a case where $_POST was empty in IE when submitting a modal when $form_state['has_file_element'] was set to true -- #1158928: Set $form_state['has_file_element'] only when file element is accessible

comment #17 helped with #1208094: Filefield AJAX editables break when more than one is included on the page

I am going to close this issue since the primary purpose was already solved. If this is still an issue, feel free to open a new one in the queue!