Hi,

Great module, nice work. We would like to use it for a project, but we need a bigger flash display. I added the width/height params to the file upload form. If you have some time please review my patch.

Thanks,
Peter

CommentFileSizeAuthor
#1 issuu-949610.patch3.37 KBitarato

Comments

itarato’s picture

itarato commented
StatusFileSize
new issuu-949610.patch3.37 KB
marvil07’s picture

marvil07 commented
Status: Needs review » Closed (duplicate)

Thanks for the patch.

I'm marking this as duplicate of #940380: Provide options to customize the formatter outputs, so please post there the follow-ups

+++ issuu.module	22 Oct 2010 13:18:57 -0000
@@ -437,6 +457,10 @@ function theme_issuu_formatter_ffpagefli
+  $width = empty($element['#node']->{$element['#field_name']}[0]['data']['issuu_width']) ? ISSUU_DEFAULT_WIDTH : $element['#node']->{$element['#field_name']}[0]['data']['issuu_width'];
+  $height = empty($element['#node']->{$element['#field_name']}[0]['data']['issuu_height']) ? ISSUU_DEFAULT_HEIGHT : $element['#node']->{$element['#field_name']}[0]['data']['issuu_height'];
+

We need to avoid hardcoding the values (no use 0 as first element)

+++ issuu.module	22 Oct 2010 13:18:57 -0000
@@ -464,6 +488,10 @@ function theme_issuu_formatter_ffpresent
+  $width = empty($element['#node']->{$element['#field_name']}[0]['data']['issuu_width']) ? ISSUU_DEFAULT_WIDTH : $element['#node']->{$element['#field_name']}[0]['data']['issuu_width'];
+  $height = empty($element['#node']->{$element['#field_name']}[0]['data']['issuu_height']) ? ISSUU_DEFAULT_HEIGHT : $element['#node']->{$element['#field_name']}[0]['data']['issuu_height'];

We need to avoid hardcoding the values (no use 0 as first element)

In the other side, they are not the only custom parameters we can pass to the embed, so we need to add them all(see the embed button on the issuu pages such as http://issuu.com/nanomag/docs/nano_light)

Powered by Dreditor.