Using the Coder module to check any inconsistencies with the drupal coding standards.
This patch fixes: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE

CommentFileSizeAuthor
#8 861566-completely-revert-system-tar-inc.patch31.65 KBStevel
#7 861566-revert-system-tar-inc.patch30.77 KBStevel
coding_standards_0.patch31.49 KBp.brouwers

Comments

p.brouwers’s picture

p.brouwers commented
Status: Active » Needs review
aspilicious’s picture

aspilicious commented 
+++ /var/www/drupal/modules/system/system.tar.inc	2010-07-22 14:53:51.000000000 +0200
@@ -1856,12 +1856,12 @@ class Archive_Tar
+		      && (($v_position = strpos($p_path, ':')) != FALSE)) {

Remove these tabs

40 critical left. Go review some!

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

damien tournoud’s picture

damien tournoud commented

Hm.

Do we really want to start hacking our standards into system.tar.inc? This means forking, boys. And forking means maintaining.

damien tournoud’s picture

damien tournoud commented
Status: Fixed » Active

I suggest we revert this patch.

aspilicious’s picture

aspilicious commented

This patch contained tabs...
Revert?

Stevel’s picture

Stevel commented
Status: Active » Needs review
StatusFileSize
new 861566-revert-system-tar-inc.patch30.77 KB

Here's a plain revert of the changes to system.tar.inc

Stevel’s picture

Stevel commented
StatusFileSize
new 861566-completely-revert-system-tar-inc.patch31.65 KB

Or should we be going further back? http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc

I think none of the changes made are necessary for the correct functioning, so I don't think it's worth forking it for code style (or other) compliance.

Also, a newer version of the Archive_Tar project is available from http://pear.php.net/package/Archive_Tar/. Should we include the newer version, or is the current one just fine?

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Fixed

This is now a duplicate of #870204: Revert coding style changes to system.tar.inc & other externally developed files.

Status: Fixed » Closed (fixed)
Issue tags: -Coding standards

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Coding standards

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.