Increase size of init field on users table to 254 characters

Do not use hook_schema() from within hook_update_N() http://drupal.org/node/150220

So both fields' changed are placed within user_update_7005()

@marcingy Yes, I forget about this change.

patch is trivial so RTBC

Same patch but doc-block comment trimmed to standard.

Grrr wrong patch...

@marcingy About #5 read more at Coding standards and about Doxygen http://drupal.org/node/1354#functions

Also it's could be great if you add comment about why 254 chars was chosen from #502968: Increase maximum allowable length of email addresses

+ * Change the users table to allow longer email addresses.

Please change the verb to "changes".
I know there are a lot of places in core not following the standard but we try to do our best with new patches.

I'm OK with this change. In Drupal, we tend to write 'e-mail' instead of 'email' though.

While we are at it: db_change_field() mandate that you drop and recreate the indexes on the changed fields. We have an index on 'mail', so the code should read:

  db_drop_index('users', 'mail');
  $mail_field = array(
    'type' => 'varchar',
    'length' => 254,
    'not null' => FALSE,
    'default' => '',
    'description' => "User's email address.",
  );
  db_change_field('users', 'mail', 'mail', $mail_field, array('indexes' => array('mail' => array('mail'))));

If you going to add the reference, you have to put a newline between the first sentence of the docblock and the see

+ * Changes the users table to allow longer e-mail addresses.
+ * See http://drupal.org/node/502968 for further discussion.

We don't usually put links to issues in code comments - otherwise we'd have thousands of them, and cvs annotate lets you find the issue with a bit of work, apart from that looks RTBC although I didn't test it.

Committed to CVS HEAD. I'm moving this to HEAD 2 HEAD.

Let's not move core issues to the queue of a module that about 5 people are using :) Instead we can just create separate issues in Head to Head and crosslink them. (Most people probably aren't interested in the Head to Head issue, and moving it there also prevents the core change from being widely visible or easily reopened for any necessary followups that might arise.)

In this case, @catch already opened a Head to Head issue preemptively anyway:

#809428: {users}.init length

I've posted a patch there.