I love driven and how awesome it is! But I love ajax comments module as well. A compatibility would be great. Thanks!

http://drupal.org/project/ajax_comments

Comments

arhak’s picture

Status: Active » Postponed (maintainer needs more info)

tough one
- what effect did you get?
- screenshots available?

it can't be achieved without collaboration from ajax_comments, both of these modules are aggressive regarding the comment's form
if we start conversations we might find a middle point, but haven't heard from them being interested regarding foreign modules support, it seems they have enough with their own problems to start digging in other directions #572144: Doesn't work with Comment Subjects module

Flying Drupalist’s picture

Well the situation is if I turn on ajax comments ajax comments work perfectly. I don't see anything from Driven at all.

I don't really know what's going on, but perhaps you can set driven to overwrite ajax comment's form edits after it's already done?

I'll be uninstalling this module for now as I need ajax comments. Thanks!

arhak’s picture

Status: Postponed (maintainer needs more info) » Postponed

ajax comments work perfectly. I don't see anything from Driven at all.

for me this is enough good news

perhaps you can set driven to overwrite ajax comment's form edits after it's already done?

this module is so aggressive with the comment_form that it has weight 1000
really don't know why our form_alter isn't showing up (broken at least) not showing at all.. will have to dig into it.

I'll be uninstalling this module for now as I need ajax comments

is a shame, but right now we can't afford giving priority to this
we should

PS: comment_cck and/or comment_alter_taxonomy (or any other comment module you might know) play nice with ajax_comments? it would be nice to have some guidance the day we pick up this

Flying Drupalist’s picture

Thanks for making a great module. I wish my needs weren't so convoluted that I could use it.

I know that comment_cck does not work.

arhak’s picture

I wish my needs weren't so convoluted that I could use it.

I won't close this issue.
Lets get this module less "unstable" and we'll see what comes next.

I know that comment_cck does not work.

oh, please, don't get me wrong. It wasn't a rhetorical question.
I'm actually asking you if you know any module somehow involved with comments which plays nice with ajax_comments. Any hints on this might come handy.
I'm also co-maintainer of comment_subject, which isn't fully working with ajax_comments, and haven't had the time to spare on it.

arhak’s picture

Status: Postponed » Postponed (maintainer needs more info)

I tried this today with ajax_comments 6.x-1.8

- the driven fieldset appeared wherever the ajax comment form was
- the submission got an AJAX error, but worked, i.e. the data was submitted and properties were changed
- the preview was not good at all

warning: array_shift() [function.array-shift]: The argument should be an array in .../ajax_comments.module on line 119.

haven't looked what caused it, yet

but definitely will need cooperation from ajax_comments, since they are dropping #after_build without considering other modules that might be adding their own (like comment_driven does)

  if ($form_state['post']['op'] == t('Preview')) {
    $form['#after_build'] = array('comment_form_add_preview');
  }

I would be needing more feedback on this
if you really would like these modules to be compatible, please provide more details regarding your configuration to know why driven fieldset didn't show up

EDIT: typo what/why

Flying Drupalist’s picture

Thanks for taking this up again.

I'm using the dev rather than 1.8. I don't get that line 119 error on the latest dev, which I think I do on 1.8.

arhak’s picture

Status: Postponed (maintainer needs more info) » Active

so, you're using latest dev
and you don't see the driven fieldset to appear at all, right?

the 119 error was attempting preview with driven fieldset in an ajax-comment,
if you don't see driven fieldset at all, I guess you shouldn't get that error neither

ajax_comments compatibility doesn't sound that bad (according to a superficial review)

Flying Drupalist’s picture

That's right. Thank you so much again.

ManyNancy’s picture

+1

arhak’s picture

Category: feature » support
Status: Active » Needs work

haven't found the time to spare on this

ManyNancy’s picture

Thanks for keeping us updated. Looking forward to testing it.

Flying Drupalist’s picture

Yes, thanks for the update.

arhak’s picture

Version: 6.x-1.0-unstable3 » 6.x-1.x-dev
Status: Needs work » Needs review

far from ready, but at least works

what to do after a comment submission?
the node won't update its properties to reflect the change,
then the page will be innacurate
this will need a lot of AJAX work to proper display changes
I think this requires involvement from the ajax_comments side

arhak’s picture

@#14 wait a minute.. lets make some points clear:

ajax_comments-6.x-1.8 can receive more support / bug fixes

but 1.9 can't be supported by cdriven, it has to be the other way around
since it starts relying on comment_bonus_api-6.x-1.x-dev,
which is taking form processing completely out of the way and directly using comment_render
i.e. there is no way to hook in that flow

it would have to be comment_bonus_api/ajax_comments the ones being aware of this module

then:
- for 1.8 feedback is welcome (probably preview won't be supported, unless ajax_comments would like to support an actual form instead of the used dummy comment_form)
- for 1.9 it would be a "won't fix" from this side unless contacted by comment_bonus_api maintainers

Flying Drupalist’s picture

I'll try to create a test environ and downgrade, but I recall running into bugs back in 1.8

arhak’s picture

@#17 I'm seeing bugs in dev which were in 1.8, it doesn't seems to make too much difference right now
besides, the project seems pretty much abandoned (not to mention bonus_api)

arhak’s picture

Priority: Normal » Minor
Status: Needs review » Closed (won't fix)

sorry folks, its been a month without feedback
nevertheless, reopen if you think appropriated AND willing to contribute at the very least with proper feedback
PS: keep in mind that chances are not good, since 1.8 won't accept patches and dev has bonus_api

Flying Drupalist’s picture

Sorry for taking so long to get back to you on this, but downgrading is not really possible. I would be happy to put up $100 for a patch for bonus api to get it to suck less.