While testing various cases of #539052: Before clicking edit button on existing signup, only Attendance select box is disabled, I noticed that a user without perms to edit their own signup gets an enabled status selector form element, even though there's no submit button.

CommentFileSizeAuthor
#1 583010-1.signup_status_no_edit.patch1.9 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 583010-1.signup_status_no_edit.patch1.9 KB
mlsamuelson’s picture

mlsamuelson commented
Status: Needs review » Reviewed & tested by the community

The patch fixes the behavior. A user with only Create Signups and Cancel Signups could previously toggle the status (ie. it wasn't disabled) though there was not edit/save button. After the patch, the status dropdown is disabled as desired.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks for testing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

donquixote’s picture

donquixote commented
Status: Closed (fixed) » Needs work

I have a problem in Opera:
Users with permission to change their signup status can't do so in Opera.

The reason is that the fieldset is still set to disabled="disabled". In Opera this has the effect that all child elements are disabled too.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Closed (fixed)

@donquixote: That's a separate bug from this issue. Please open a new issue for that.

donquixote’s picture

donquixote commented

Here we go,
#662848: fieldset with disabled="disabled" will disable all child elements. (Signup Status, Opera)

I thought that this bug was probably introduced with the fix discussed here, but this was just a guess.