Closed (fixed)
Project:
Signup
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
15 Sep 2009 at 22:23 UTC
Updated:
4 Oct 2009 at 23:20 UTC
Jump to comment: Most recent file
For a variety of reasons, it'd be nice to move all of the signup-related settings from node/N/edit to a new "Settings" sub-tab at node/N/signups/settings:
A) There are a lot of potential use-cases where a given user can admin signups on a node that they can't otherwise edit. These folks should be able to tweak signup-related settings.
B) The JS to conditionally hide/show signup-related settings when you toggle if the node is signup-enabled or not gets really complicated once other signup submodules are trying to inject their own settings, e.g. over at #359412: Move code for signup limits per status per node into a submodule.
C) It's potentially confusing UI that there are multiple places to tweak some of these settings, e.g. the global signup limit for the node.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 578502-6.signup_views_node_signup_settings_link.patch | 1.61 KB | dww |
| #3 | 578502-3.signup_node_settings.tab_.png | 103.48 KB | dww |
| #2 | 578502-2.signup_node_settings.existing-node.png | 27.43 KB | dww |
| #2 | 578502-2.signup_node_settings.new-node.png | 16.45 KB | dww |
| #1 | 578502-1.signup_node_settings.patch | 18.72 KB | dww |
Comments
Comment #1
dwwComment #2
dwwFYI, here are screenies of node/N/edit when a) editing an existing signup-related node with some signups and b) a new node...
Comment #3
dwwOh, and here's an example node/N/signups/settings tab
Note that I haven't fixed (C) yet by cleaning up the "Signup summary" form at the top of node/N/signups/admin
Comment #4
dwwPoint (C) from the original post will be fixed over at #578592: Cleanup + fix the "Signup summary" at the top of node/N/signups/admin. Given that I tested this heavily during development, I committed to HEAD and DRUPAL-6--1. Folks are encouraged to test DRUPAL-6--1 ASAP and let me know if this introduced any problems so that I don't ship RC6 with any bugs in this area.
Thanks!
-Derek
Comment #5
dwwForgot to include an option for the "Signup: Node: Signup link" views field...
Comment #6
dwwNote: for testing, you might want to apply #582626: Visibility logic for "Signup: Node: Signup link" views field is wrong to fix a bug in that views handler...
Comment #7
mlsamuelson commentedApplied #582626: Visibility logic for "Signup: Node: Signup link" views field is wrong and then this patch and it resolves the issues I was experiencing.
Comment #8
dwwCommitted to HEAD and DRUPAL-6--1. Thanks!