Overview

Dropping a new component into a Global Region sends updated JSON to the server but the HTML returned from the server does not render the newly added component.

Steps

  1. Delete page title block
  2. Switch to the Library tab and drag and drop an SDC component into the focused region in the preview
  3. Observe that the JSON sent to the server contains the newly added component
  4. Observe that the HTML returned from the server does not have the newly added component
  5. Refresh the page - observe that the newly added component appears in the layers panel but not in the preview

CommentFileSizeAuthor
Drupal_Experience_Builder.png93 KBjessebaker

Comments

jessebaker created an issue. See original summary.

jessebaker’s picture

jessebaker commented

I've just done a fresh install on 0.x after merging in the global region work and I'm no longer seeing the issue.

I'm still working in this area. Will update this issue if I come across the issue again or have better steps to reproduce.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Dropping a component in a global region does not update the preview » Global region preview when the page template is invalid
Priority: Critical » Major
Issue summary: View changes

I noticed this can happen page template config is invalid for one reason or another. This can be reproduced by trying to delete page title block. It was pretty confusing so we should keep this open.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Global region preview when the page template is invalid » [PP-2] auto-saved PageRegions may be invalid, but MUST NOT cause XB's previews to fail.
Status: Active » Postponed

WRT PageTemplate validation

#3505872: Page title block should not be required landed, so #3 cannot happen anymore.

#3501600-17: Split 1 PageTemplate config entity into N PageRegion config entities describes how we'll be able to drop most validation, probably all the validation that caused #3 in the first place.

So let's wait for #3501600: Split 1 PageTemplate config entity into N PageRegion config entities to land, and then re-assess this.

Related, at a different level

This is level up from #3485878: Server-rendered component instances should NEVER result in a user-facing error, should fall back to a meaningful error instead (+ log), but is comparable in intent. A "level up" in the sense that that is about individual component instances, and this is about a tree of component instances.

So let's wait for #3485878: Server-rendered component instances should NEVER result in a user-facing error, should fall back to a meaningful error instead (+ log) to land too, and then re-assess this.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: [PP-2] auto-saved PageRegions may be invalid, but MUST NOT cause XB's previews to fail. » Auto-saved PageRegions may be invalid, but MUST NOT cause XB's previews to fail.
Status: Postponed » Active

The blocking issues have landed now.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Tangentially related #3530857: ApiLayoutController::buildPreviewRenderable() always auto-saves regions regardless of $updateAutoSave value landed earlier today.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » mayur-sose
Status: Active » Postponed (maintainer needs more info)

@mayur-sose, could you please check if this is still reproducible? 🙏

mayur-sose’s picture

mayur-sose commented

@wim-leers, I attempted to reproduce the issue, but was unable to do so. Here are the steps I followed:

  1. Added the Page Title component to the canvas.
  2. Deleted the Page Title block.
  3. Added the Hero component to the canvas.
  4. Refreshed the page and confirmed that the Hero component appeared correctly in both the Layers panel and the preview.

I also tried several other scenarios to replicate the issue, but it did not occur in any of them.

mayur-sose’s picture

mayur-sose commented
Assigned: mayur-sose » Unassigned
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

🥳 Thanks, @mayur-sose! Crediting you for that :)