Overview

While working on #3460760: CI: improve UI-related CI jobs:`UI eslint` obscures TypeScript Compiler errors, `npm run build` runs too late, I was reminded of what I observed a few weeks ago: that changes exclusively in the ui/ directory still run all the back-end-only CI jobs, such as phpcs, phpstan and phpunit.

(Well, phpunit is affected also by changes to the components directory, since it tests the PHP logic finding matches for each component prop — but SDCs themselves are running on the back-end too. Easy enough to take into account.)

User interface changes

None. Faster CI runs for UI-only changes.

CommentFileSizeAuthor
#3 Screenshot 2024-07-11 at 1.02.09 PM.png294.69 KBwim leers
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Assigned: wim leers » Unassigned
Status: Active » Reviewed & tested by the community
StatusFileSize
new294.69 KB

This MR touches only .gitlab-ci.yml, and so there's no point in running most CI jobs … which now actually is the case:

🥳🚀

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed b0fd109a on 0.x
    Issue #3460778 by Wim Leers: CI: do not run PHP-only jobs if an MR only...
wim leers’s picture

Assigned: Unassigned » wim leers
Status: Fixed » Needs work

This caused a regression. CI jobs are not running when they should:

😭

wim leers’s picture

I've read and re-read https://docs.gitlab.com/ee/ci/yaml/#rulesif and I can't make sense of why it's not working. Attempted fix on another issue/MR failed: https://git.drupalcode.org/project/experience_builder/-/merge_requests/6...

  • Wim Leers committed 4ec1a479 on 0.x
    Issue #3460778 by Wim Leers: CI: do not run PHP-only jobs if an MR only...
wim leers’s picture

Assigned: wim leers » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.