Follow-up for #3450307: CI: use template's `eslint` job to validate YML and JS, add new `UI eslint` job for UI's TypeScript.
@bnjmnm raised 2 DX/velocity concerns while he was working on #3452512: Add component instance edit form to contextual panel:
UI eslint CI job. It does not provide clear errors for TS failures, due to us running npm run lint in that CI job and: "build": "tsc --noEmit && vite build",
…
"lint:eslint": "eslint . --max-warnings=0",
"lint": "npm run type-check && npm run lint:eslint",
Cypress CI job is currently actually building the UI (npm run build). That makes no sense: that CI job should not even be triggered if the build fails — there should be an explicit failure for that instead.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screenshot 2024-07-11 at 11.33.25 AM.png | 253.27 KB | wim leers |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wim leersA TypeScript error now results in NO more linting, NOR Cypress testing:
Comment #4
wim leersAnd now the
CypressCI job is faster! It no longer runsnpm run build, not evennpm install— because it receives all that work from the earlierUICI job 👍Bonus: #3460778: CI: do not run PHP-only jobs if an MR only changes the UI will improve the DX for JS UI-only changes further 😊
Comment #5
wim leersI see now the issue title was wrong — but the summary was right 🙈
Comment #7
wim leers