Remove xmlsitemap_menu.module

it really doesn't add any more complexities compared to an xmlsitemap_taxonomy or xmlsitemap_node

The difference is that those modules are really needed, if we don't want the users insert each links by hand in the site map.

My judgement is based on the past issue reports I read about that module; it's also based on the fact that this project has become a blob of code that could be slimmed down a little (I am talking of the 6.x-1, and Drupal 5 branches). As somebody else already suggested, the project code should contain just what it really needs; the rest (like the part that change the links priority basing on the number of comments added to the node) can be put in a module that doesn't need to be included in this project.

Another reason to remove the module, and use only the other approach is that the way of adding custom links through xmlsitemap_menu.module makes the operation too complicated. Imagine the user that must create a menu item in a menu, which must be first created if it doesn't exist already; it would be easier for him to write something into a text area, without the need to pass to a different settings page (after he notices that the module settings page makes reference to a custom menu).

Let us proceed in order; the first step should be to remove in the old branch, and then in the new branch.
We should have the same modules in both the branches, anyway.

To add the links to view in the sitemap is enough for the user to be able to add relative URLs through a text area.
I have seen people adding the navigation in the list of menus the module should use to populate the sitemap, and wondering why Google Webmaster Tools was complaining about a 403 error; I know the problem was caused by the module not checking the access permission, but my point is that the module has been overused.

I am taking it back to the 6.x-1 branch because I am going to remove the module.
The module that cannot use a Drupal hook to know when a single menu item is deleted for the simple fact that such hook doesn't exist, or it's not called from Drupal core code; being this the situation, to be sure the module doesn't leave links to menu items that have been deleted, it must remove all the links it had inserted in the sitemap table earlier.

The presence of this module doesn't allow me to optimize the code, and change it to create the sitemap content in a progressive mode. The actual code does create the sitemap content all in once, and this causes problems when the number of links to add is higher than a limit (maybe 5000, less or more).

This task has been completed.

The task should be re-applied, as the module is back again.

Removing files from CVS repository is not done by a patch; the patch could be used if you are suggesting to leave a shell module, which is what you didn't want to do with xmlsitemap_term.module (see the issue titled Why do we need the shell module, or something close).